port fiber changes from codal for PXT GC support

lancaster-university / microbit-dal

http://lancaster-university.github.io/microbit-docs

Other

256 stars 130 forks source link

port fiber changes from codal for PXT GC support #424

Open mmoskal opened 5 years ago

mmoskal commented 5 years ago

CC @abchatra

abchatra commented 5 years ago

@mmoskal Can you please merge this? Also if possible create the right tags in the repos so we can point to it.

finneyj commented 5 years ago

@mmoskal @abchatra

Would you mind holding off on merging until I've had chance to review the changes to the scheduler fully? Some changes in this PR are pretty deep, and I feel another pair of eyes on it can only help. I'll try to find time in the next 24hrs...

abchatra commented 5 years ago

Sure @finneyj. Sorry, I thought review was completed. (Green tick only means review requested 😞 ).

finneyj commented 5 years ago

Thanks for all the work on this @mmoskal.

Generally all looks positive. Happy to merge pending questions I've posted as line comments - so could you take a look at those?