search

lancaster-university / microbit-dal

http://lancaster-university.github.io/microbit-docs
Other
256 stars 130 forks source link

triple-tap-reset to enter pairing mode #486

Closed jaustin closed 2 months ago

jaustin commented 1 year ago

in CODAL we've implemented a really nice feature that lets a user enter pairing mode by triple-tapping the reset button.

https://github.com/lancaster-university/codal-microbit-v2/tree/triple-reset-to-pair

For us to move to this as the primary pairing mechanism we'll need to ensure it's in microbit-dal too.

@finneyj @JohnVidler could you please port this to microbit-dal before we make the next DAL release?

whaleygeek commented 1 year ago

@jaustin See this, for some motivation to get this done!!!

https://twitter.com/jerseyitguy/status/1622205053640622080

microbit-carlos commented 1 year ago

We working on this ticket we can take the opportunity and remove some start up delays as well: https://github.com/lancaster-university/microbit/blob/1d1baa561f82ab0d16d1916b0026955c67d95e74/source/MicroBit.cpp#L133

martinwork commented 1 year ago

See https://github.com/lancaster-university/codal-microbit-v2/issues/348

martinwork commented 10 months ago

Created https://github.com/lancaster-university/microbit/pull/20 with animation delay reduced form 50ms to 20ms.

@microbit-carlos Would you like me also to remove the 100ms delay? https://github.com/lancaster-university/microbit/blob/1d1baa561f82ab0d16d1916b0026955c67d95e74/source/MicroBit.cpp#L133 I don't see any evidence as to why it was added, but it seems to have always been there.

carlosperate commented 10 months ago

@finneyj when you were looking at startup timings for the tripple-press-to-pair in V1 DAL, did you notice the delay's from Martin last comment? And do you know if they are safe to remove? (or worth removing?)

microbit-carlos commented 2 months ago

Any solutions we have thought about to tackle this feature are too invasive or complex, so we've decided not to implement triple reset to pair mode in V1.