search

lancaster-university / microbit-docs

http://lancaster-university.github.io/microbit-docs
Other
27 stars 28 forks source link

uBit.bleManager.advertiseEddystoneUrl: URL length #39

Closed OwenBrotherwood closed 7 years ago

OwenBrotherwood commented 7 years ago

a proposed explanation of the URL length without listing all the byte encoding possible.

OwenBrotherwood commented 7 years ago

Oops :)

OwenBrotherwood commented 7 years ago

Or rather Oops, corrected

OwenBrotherwood commented 7 years ago

update of text with focus on the URL prefix and the the remaining characters 

where the https:// is encoded as one byte and is placed in the URL prefix and the remaining 14 characters are placed in the available space of 17
OwenBrotherwood commented 7 years ago

Can this PR be merged? Downstream repository is waiting for this PR in order to finish a PR on their doc.

OwenBrotherwood commented 7 years ago

Apologies Lancaster. Although the text supplied is ok, I have not created a correct formatting of the presentation at https://lancaster-university.github.io/microbit-docs/ble/eddystone/#starting-advertising I seem to have missed the possibility of paragraphs to break the text up into correct paragraphs.

I can create another PR if Lancaster wishes a correction or feel free to change the formatting (and of course any text at Lancaster's discretion).

jamesadevine commented 7 years ago

Sure, i thought it looked ok!

OwenBrotherwood commented 7 years ago

OK: I am happy if Lancaster is happy. Thanks James