search

lancaster-university / microbit-v2-samples

CODAL build tools and sample programs for the micro:bit v2.x
MIT License
64 stars 83 forks source link

Fix build in a folder with spaces in its path #10

Closed martinwork closed 2 years ago

martinwork commented 3 years ago

Fixes error when building inside, for example, "New folder" AR10B2~1.EXE: error: folder/microbit-v2-samples/build/codal_extra_definitions.h: No such file or directory AR10B2~1.EXE: error: folder/microbit-v2-samples/utils/cmake/toolchains/ARM_GCC: No such file or directory

jamesadevine commented 3 years ago

@martinwork adding quotation marks fixes spaces in the path? Awesome! Curse me for being a good dash and underscore user (I can't stand spaces in paths).

I think this patch would be better applied to https://github.com/lancaster-university/codal and then upstreamed here. Maybe you could advise on better merge strategy as I'm not sure how much divergence there is from the main codal repository and this one...

martinwork commented 3 years ago

It works for me, with "Visual Studio" in the path. I've never visited https://github.com/lancaster-university/codal. I don't mind if you want to make the change there, upstream, and close this.

microbit-carlos commented 2 years ago

@JohnVidler if you can apply this patch upstream and then pull it down here we can close this PR.

JohnVidler commented 2 years ago

Looks like a very minor patch, and I don't see any side effects to happy to merge in; thanks @martinwork 👍

microbit-carlos commented 2 years ago

@JohnVidler I think the same patch can be applied to https://github.com/lancaster-university/codal as well, in case you'd like to push it there too.