lancaster-university / microbit-v2-samples

CODAL build tools and sample programs for the micro:bit v2.x
MIT License
68 stars 88 forks source link

Building on windows: issue and solution. #14

Closed LovelyXandy closed 1 year ago

LovelyXandy commented 3 years ago

Took me a while to work out - the build.py (and associated scripts) on a windows machine fail with a not very useful error if the directory path contains a space character (which github desktop defaults to including); they also won't download the libraries from the other githubs unless the path to the git command line executable is added (which the desktop github for windows doesn't do automatically).

finneyj commented 3 years ago

Thanks for reporting @LovelyXandy. Sorry to hear you didn't have the smoothest ride here.

Perhaps you could advise a fix when you have a bit of spare time @jamesadevine? I think you know that script better than anyone?

jamesadevine commented 3 years ago

Have you got a repro @LovelyXandy?

martinwork commented 3 years ago

I think https://github.com/lancaster-university/microbit-v2-samples/pull/10 will help build.py work with spaces.

I haven't hit the problem with the git command path.

microbit-carlos commented 2 years ago

@JohnVidler I think PR #10 needs to be ported to the upstream lancaster-university/codal repo, specially with the bootstrap using the tooling from there.

microbit-carlos commented 1 year ago

PR created:

microbit-carlos commented 1 year ago

Done 🎉