Open microbit-carlos opened 1 year ago
The CMakeLists.txt file just check if it has any value, so if the user sets "dev": false in the json file, it will still treat it as a dev build. https://github.com/lancaster-university/microbit-v2-samples/blob/ce0d2aa3c3d0c5c656dff8f833c3d39945ed10cb/CMakeLists.txt#L67-L73
CMakeLists.txt
"dev": false
As the codal.json file in this repository contains "dev": true it's a fair expectation that changing it to false should disable it.
codal.json
"dev": true
false
A fix in this repo should also be pushed upstream to lancaster-university/codal and to codal bootstrap (if applicable).
The
CMakeLists.txtfile just check if it has any value, so if the user sets"dev": falsein the json file, it will still treat it as a dev build. https://github.com/lancaster-university/microbit-v2-samples/blob/ce0d2aa3c3d0c5c656dff8f833c3d39945ed10cb/CMakeLists.txt#L67-L73As the
codal.jsonfile in this repository contains"dev": trueit's a fair expectation that changing it tofalseshould disable it.A fix in this repo should also be pushed upstream to lancaster-university/codal and to codal bootstrap (if applicable).