Closed broccoliSpicy closed 1 week ago
ACTION NEEDED Lance follows the Conventional Commits specification for release automation.
The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.
For details on the error please inspect the "PR Title Check" action.
This is based on TPC-H testing right? Do you need
<= 256
? Or is< 256
ok? I thought one of the columns had a max length of 256?
in the TPC-H schema, the largest string length it has is 199
in
CREATE TABLE partsupp
(
ps_partkey BIGINT not null,
ps_suppkey BIGINT not null,
ps_availqty BIGINT not null,
ps_supplycost DOUBLE PRECISION not null,
ps_comment VARCHAR(199) not null
);
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 77.11%. Comparing base (
3f2faf2
) to head (37fe3bf
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This PR tries to fix a logic error during selecting miniblock encoder.