Closed westonpace closed 1 week ago
Attention: Patch coverage is 66.66667%
with 5 lines
in your changes missing coverage. Please review.
Project coverage is 77.13%. Comparing base (
c237bcb
) to head (b5117b9
).
Files with missing lines | Patch % | Lines |
---|---|---|
rust/lance-encoding/src/encoder.rs | 16.66% | 5 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
some benchmark results related to this PR: before eliminating copy:
after eliminating copy:
We align buffers in the file writer but we were not doing the same thing in the test utility. This forced encodings to do extra copies. We remove one such copy in this PR.
Closes #3115