Closed wjones127 closed 2 days ago
Attention: Patch coverage is 73.83178%
with 140 lines
in your changes missing coverage. Please review.
Project coverage is 77.94%. Comparing base (
c47543f
) to head (60505db
). Report is 2 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
🚨 Try these New Features:
One other thought I had. Could the insert builder have a way of generating a collection of fragments instead of a transaction? E.g. how would I use it if I wanted to run the insert builder twice and then commit both sets of files as a single transaction later?
😄 Later today I'll have a PR that adds a new API to CommitBuilder
: CommitBuilder::execute_batch(transactions: &[Transaction]) -> BatchCommitResult
. This will merge all compatible transactions together into a single transaction and commit that. This makes it kind of a nice API for distributed writes, and at the same time serves as a poor-man's multi statement transaction.
BREAKING CHANGE: return value in Rust of
write_fragments()
has changed toResult<Transaction>
.InsertBuilder
andCommitBuilder
.CommitBuilder
.LanceDataset.insert()
method to modify existing datasets.