search

lancedb / lance

Modern columnar data format for ML and LLMs implemented in Rust. Convert from parquet in 2 lines of code for 100x faster random access, vector index, and data versioning. Compatible with Pandas, DuckDB, Polars, Pyarrow, and PyTorch with more integrations coming..
https://lancedb.github.io/lance/
Apache License 2.0
3.97k stars 224 forks source link

fix!: low recall with cosine/dot on v3 index types #3141

Closed BubbleCal closed 2 days ago

BubbleCal commented 2 days ago

This also supports to create v3 IVF_PQ in Rust, then it introduces a breaking change

codecov-commenter commented 2 days ago

Codecov Report

Attention: Patch coverage is 73.91304% with 6 lines in your changes missing coverage. Please review.

Project coverage is 77.92%. Comparing base (c47543f) to head (6ce5d7d).

Files with missing lines Patch % Lines
rust/lance-index/src/vector/pq.rs 66.66% 3 Missing :warning:
rust/lance/src/index/vector/builder.rs 0.00% 0 Missing and 2 partials :warning:
java/core/lance-jni/src/utils.rs 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3141 +/- ## ========================================== + Coverage 77.91% 77.92% +0.01% ========================================== Files 240 240 Lines 81465 81462 -3 Branches 81465 81462 -3 ========================================== + Hits 63470 63483 +13 + Misses 14816 14812 -4 + Partials 3179 3167 -12 ``` | [Flag](https://app.codecov.io/gh/lancedb/lance/pull/3141/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lancedb) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/lancedb/lance/pull/3141/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lancedb) | `77.92% <73.91%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lancedb#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features: