lancehalberd / spirit-world

Zelda-like adventure game
Other
2 stars 2 forks source link

cavearranged2 edits #38

Open Kaimatten opened 1 year ago

Kaimatten commented 1 year ago

A while back you sent me a new version of cave arranged which shifts the northern jumpable ledges from the bottom of the tile to the north. I think this is probably a good change to make the tiles more consistent, but there are a couple of issues. First, the new tiles don't seem to be quite aligned, one has a piece of a nearby tile when used as well as a small gap in the ledge. Second, if we make this change, I think we should apply the same change to the impassible ledges so that they are both consistent.

This is unrelated, but the cave floor corner and ledge graphics don't line up well currently, in the screenshot you can see some grass pixels peaking through where I tried to put the cave floor corners over the grass and under the ledges. If that can be cleaned up somewhere as well that would be great.

At some point it would be good to do a pass to make the transition between the curved ledges and the straight ledges a little smoother as well.

Image

Kaimatten commented 1 year ago

Pass to fix the misaligned north tiles and edge tiles. Also I think fixed the missing tiles that show through to the grass underneath. I changed the edges to be only 2 px wide in general so it changes into the slopes better. It does make the edges a little less obvious due to being thinner, but probably is still fine at least to make sure it works for now.

Image

Kaimatten commented 1 year ago

Red variation if you are using this too

Image

lancehalberd commented 1 year ago

I'm working on adding this now, so far everything looks good, except I noticed one additional curved floor tile I would like to update here:

Image

It looks like the curved tiles for the light grey spirit floor has the same issue as well. At some point maybe you can review all of these curved tiles to make sure they are the same.

lancehalberd commented 1 year ago

By the way, I quite like the new ledges compared to the old ones. When we are pretty confident we have all the bugs worked out, we should do another pass to make sure any similar style of ledges are updated to match these in terms of placement+thickness.

Kaimatten commented 1 year ago

Crystal Tileset Image

Stone Tileset Image

Cave+Redcave tileset Image Image

I did the same edits for the north ledges and the curves for the stone and crystal tileset. Also shrank the edges on them to be more similar to what I did with the cave tilesets, although the crystal tileset may need more testing. There was also a stray pixel in one of the curves in the cavesets, so I edited those.

I'm having trouble finding which spirit tileset you are referring to. Can you upload it?

lancehalberd commented 1 year ago

Sure, it is this small one called spirit floor. If you don't recall it, I might have made it based on the cave floor tiles.

Image

Kaimatten commented 1 year ago

Unsure if I made it, but was easy to fit to the new version! See if this works with the current ledges: Image

lancehalberd commented 1 year ago

That works well. However, the top ledges for the cavearranged are 1 pixels too short now for both the light and dark versions. It looks like they just need 1 more pixel on the left.

Kaimatten commented 1 year ago

Image

Image

Image Image

Checked all 4 for that ledge to make sure all had that ledge filled out. Stonetileset also was missing 1 pixel - unsure what happened. Reposted all of them to keep them together just in case, but it should be fixed on these.