search

lanceseidman / PiCAST

PiCAST turns your $35 Raspberry Pi in to a Chromecast like Device.
https://munchron.com
1.77k stars 264 forks source link

Fixes typo and add missing flag when creating db #12

Closed maurorodrigues closed 11 years ago

maurorodrigues commented 11 years ago

To run MySQL commands from the command line we must add -e flag, like: sudo mysql -uroot -pthePICAST -e "CREATE DATABASE picaster;"

Also fixes a typo in Privileges that was generating a syntax error during flush privileges.

lanceseidman commented 11 years ago

Hi, I am not sure how it passed me but I will modify this. Thanks!

maurorodrigues commented 11 years ago

Hi So just a question: why didn't you just accept the pull request? I know it's your project, your rules...

But it's not the first time.. there is 7 pull requests closed and none of them accepted and in at least two (mine and @jd1 ) of them you copied the content and created a commit with you as author.

You know I'm really happy making this contribution, and I'm planning to do more, but you must realize: when someone contribute to your project that doesn't mean that you have the right to take that person's contribution and put your name on it.. Open source is a two way road: you are contributing but obviously you want to see your effort recognized and fell like part of the project even with a small contribution like this one, ending up with a positive karma and excited to continue helping with other features/bugs.

At next time at least copy the patch completely man! ;) You forgot the typo in PRIVLEGES to PRIVILEGES.

lanceseidman commented 11 years ago

Hello,

First, I am not sure of other developers you've dealt with in the past but I am not in the mood nor have the intention of taking credit for anyone's code to call it my own, which is why I haven't accepted anything from Loksly as it's good code, for the most part it's already GPL'd and someone else' project but in fairness he did make a comment about the Database in the PHP file and so forth not matching but nothing to Pull for it as that would have been the only thing I did modify from him but we found this out with another user on G+ and actually a few other items.

As for your mention of the '-e' for the SQL commands, on Google Plus someone (Balaji VP) or maybe you are him and sorry about that. If not, he also mentioned that the installer didn't work for MySQL and we worked on getting it resolved, which as mentioned on: http://www.wikihow.com/Send-Sql-Queries-to-Mysql-from-the-Command-Line we saw that I was missing the -e. I honestly thought you were him from Google Plus and just letting everyone know, which is why I didn't bother with the Pull (that and I have never done one before or I can recall; I will explain later), it wasn't personal. I assure you just almost 4 days prior we resolved his/it and only seemed like it was you but obviously it isn't. In any case, I can't go backwards but if you look at the change I referred/linked to your update, it won't occur again should you choose to make any further modifications.

Now for the PRIVILEGES, I didn't even see it as again I just saw the -e and figured you were the guy above, probably would have been smart to read the changes. Not that it's excusable but most of the updates I do are from mobile and obvious a bad idea as now I am at my desktop I see all the code where on mobile I didn't bother to scroll any further and again obviously bad idea.

As for jd1, I will look to see what was said by him/her. Most of any changes I have done in the past or added didn't get added by PULL but added and credited. I am not a big GitHub user (mainly just put code on and done), I don't really know the whole lingo/expectations but as your statement above it is its own world, it's no longer you use someones code/mod and credit them. Now I know what PULL actually is and SHOULD use if you're not looking to upset people :).

I appreciate you pointing this out to me, probably saved me a bunch of issues in the future.

-- Lance