Several improvements - Githubissues

Loksly commented 11 years ago

There are some improvements:

Easier to configure: Just one file for database configuration and for changing the default browser. All settings should be configured in just one file.
Better database abstraction. Now it's easier to change driver (mysql vs mysqli), with time I'll consider to abstract with PDO or maybe something lighter. This still needs to be improved so it may use different database engines.
Some sql code injections preventions. As none input was escaped in the original code.
Better way to check if an input was used. There's a difference between '($_GET['var'])' and 'isset($_GET['var'])'.
Other minor changes.

lanceseidman commented 11 years ago

I will definitely check out what you've done. I appreciate any and all support for the project.

I see you're speaking of escaping the input, I haven't looked yet how you do it but hopefully it understands that http:// and odd character's used in URLs are accepted.

Again, haven't seen your revisions but looking forward to reviewing and trying them.

Loksly commented 11 years ago

Hi Lance,

yesterday I saw this repository and I wanted to make some contributions. I've realized your code have some errors related to the use of the database, for example the installer.sh creates a database called "picaster" (line 67) and when you use it on PHP files you select "picasts" database (line 7 from goCAST.php). Readme file also mentions "picast" database. Another issue is the insert sentence where you try to insert on "vsweb_picast" database.

Also the Items table can be easily be improved with a different schema: (ID,kind,parameter, requestedtime) fields should be enough. I guess an Item can be only of a kind: website, youtube, and so.

I don't know if you prefer to develop this project on your own. If you don't, I can pull requests so some of these bugs can be fixed.

We'll keep in touch. Have a nice day

lanceseidman commented 11 years ago

I noticed your changes and appreciate your help. I can't use unfortunately other GPL code in the project.

Thank you, I hope you'll continue to help...

Lance

lanceseidman / PiCAST

Several improvements #13