search

lanceseidman / PiCAST

PiCAST turns your $35 Raspberry Pi in to a Chromecast like Device.
https://munchron.com
1.77k stars 264 forks source link

Comments #14

Closed Loksly closed 11 years ago

Loksly commented 11 years ago

Hi Lance,

yesterday I saw this repository and I wanted to make some contributions. I've realized your code have some errors related to the use of the database, for example the installer.sh creates a database called "picaster" (line 67) and when you use it on PHP files you select "picasts" database (line 7 from goCAST.php). Readme file also mentions "picast" database. Another issue is the insert sentence where you try to insert on "vsweb_picast" database.

Also the Items table can be easily be improved with a different schema: (ID,kind,parameter, requestedtime) fields should be enough. I guess an Item can be only of a kind: website, youtube, and so.

I don't know if you prefer to develop this project on your own. If you don't, I can pull requests so some of these bugs can be fixed.

We'll keep in touch. Have a nice day

lanceseidman commented 11 years ago

Hi,

Thank you for your time and effort. I will look at the work you've done and hopefully apply work to the project.

This project is not for me and me only, this is for EVERYONE. I want everyone to be apart of it, including you.

Thank you, Lance

-----Original Message----- From: "M Loksly" notifications@github.com Sent: ‎9/‎10/‎2013 12:14 AM To: "lanceseidman/PiCAST" PiCAST@noreply.github.com Subject: [PiCAST] Comments (#14)

Hi Lance,

yesterday I saw this repository and I wanted to make some contributions.

I've realized your code have some errors related to the use of the database, for example the installer.sh creates a database called "picaster" (line 67) and when you use it on PHP files you select "picasts" database (line 7 from goCAST.php). Readme file also mentions "picast" database. Another issue is the insert sentence where you try to insert on "vsweb_picast" database.

Also the Items table can be easily be improved with a different schema: (ID,kind,parameter, requestedtime) fields should be enough. I guess an Item can be only of a kind: website, youtube, and so.

I don't know if you prefer to develop this project on your own. If you don't, I can pull requests so some of these bugs can be fixed.

We'll keep in touch. Have a nice day

Reply to this email directly or view it on GitHub: https://github.com/lanceseidman/PiCAST/issues/14