lanceseidman / PiCAST

PiCAST turns your $35 Raspberry Pi in to a Chromecast like Device.
https://munchron.com
1.77k stars 263 forks source link

Vunerable to arbitrary command execution #45

Open ExcaliburZero opened 7 years ago

ExcaliburZero commented 7 years ago

Currently PiCAST is vulnerable to arbitrary command execution due to the fact that it uses the command line to play videos.

Here is an example of an input that would cause unintended command execution:

localhost:3000/yt-stream/$(zenity --info --text "Arbitrary Command")

In order to fix this, you may want to add a way of making sure that the youtube video id is valid and does not contain $(SOME_COMMAND).