Include Cython source in package

lancopku / pkuseg-python

pkuseg多领域中文分词工具; The pkuseg toolkit for multi-domain Chinese word segmentation

MIT License

6.51k stars 984 forks source link

Include Cython source in package #129

Closed honnibal closed 4 years ago

honnibal commented 4 years ago

Hello,

First, thanks for your work! We're using this for the new Chinese models we're releasing for spaCy v2.3.

This PR fixes a bug in your setup file that affects your current source release. The Cython files weren't being packaged, which means installation without a wheel is currently failing. This produces confusing results on Python 3.8, where no wheel installer is available.

Python packaging is very fiddly! Especially with Cython source files.

luoruixuan commented 4 years ago

Hello, Thanks for your support! I've fixed it in 0.0.25 version. Now it can be installed with source code.