search

landam / grass-gis-git-migration-test

0 stars 0 forks source link

r.what: shouldn't use static buffers for the inputs #1

Open landam opened 5 years ago

landam commented 5 years ago

Reported by 1gray on 30 Jan 2008 13:17 UTC It seems that I'm a lucky one to face all these !``static buffer!'' issues.

$ r.what \
      input=2006-08-{0{1,2,3,4,5,6,7,8,9},{1,2}{0,1,2,3,4,5,6,7,8,9},3{0,1}}.[...].{{1,2,3,4,5,6,7,8,9},1{0,1,2,3,4,5,6,7,8,9},20} \
      east_north=[...]
r.what: can only do up to 150 cell files, sorry
$

Surely I can raise NFILES in raster/r.what/main.c, but wouldn't it be better to replace all the mess in r.what with a pure dynamic buffer-based solution? (Hopefully I could make a patch.)

I've tested the command above with GRASS 6.2.3-debian-1, but I can see the relevant code in a recent SVN trunk as well.

GRASS GIS version and provenance

svn-trunk

Migrated-From: https://trac.osgeo.org/grass/ticket/32

landam commented 5 years ago

Comment by 1gray on 12 Feb 2008 13:00 UTC On the other hand, (much of) the r.what functionality could easily be achieved by using v.what.rast together with v.db.select.

Shouldn't therefore r.rast be replaced by a (supposedly simpler) Shell script?

landam commented 5 years ago

Comment by glynn on 12 Feb 2008 18:46 UTC Replying to [comment:1 1gray]:

Shouldn't therefore r.rast be replaced by a (supposedly simpler) Shell script? No. For a start, v.what.rast only accepts a single raster map. Also, r.what shouldn't depend upon the vector and database functionality (most raster modules should still work if e.g. you can't GDAL to work).

landam commented 5 years ago

Modified by hamish on 20 Aug 2009 07:39 UTC

landam commented 5 years ago

Comment by neteler on 8 Dec 2015 08:48 UTC The limit of currently #define NFILES 400 continues to exist.

landam commented 5 years ago

Comment by neteler on 8 Dec 2015 08:50 UTC See also #145

landam commented 5 years ago

Comment by neteler on 28 Jan 2016 08:02 UTC Ticket retargeted after milestone closed

landam commented 5 years ago

Comment by neteler on 28 Jan 2016 08:06 UTC Ticket retargeted after 7.0.3 milestone closed

landam commented 5 years ago

Modified by @landam on 12 May 2016 06:37 UTC

landam commented 5 years ago

Modified by @landam on 25 Aug 2016 15:51 UTC

landam commented 5 years ago

Comment by @landam on 27 Aug 2016 13:42 UTC Milestone renamed

landam commented 5 years ago

Comment by neteler on 26 Jan 2018 11:40 UTC Ticket retargeted after milestone closed

landam commented 5 years ago

Modified by neteler on 12 Jun 2018 20:48 UTC

landam commented 5 years ago

Comment by @landam on 25 Sep 2018 16:53 UTC All enhancement tickets should be assigned to 7.6 milestone.

landam commented 5 years ago

Comment by @landam on 25 Jan 2019 21:08 UTC Ticket retargeted after milestone closed