landam / grass-gis-git-migration-test

0 stars 0 forks source link

Integrate 'Change mapset' dialog in manager toolbar #174

Open landam opened 5 years ago

landam commented 5 years ago

Reported by mwortmann on 18 Sep 2015 11:59 UTC Wouldn't the simple (Settings > GRASS working environment > ) Change mapset dialog be a lot more useful in the Layer Manager toolbar? I'm not sure how many people are actually using the dialog, but I'm sure most use the commandline to do this simple change. I always thought typing 'g.mapset xyz' (plus maybe g.mapset -l) or going to the dialog, seems too much for such a simple thing. The simple dropdown without the Ok button would be quick and easy. Plus it could show the current mapset which is somewhat missing in the Layer Manager.

Migrated-From: https://trac.osgeo.org/grass/ticket/2749

landam commented 5 years ago

Comment by annakrat on 18 Sep 2015 12:47 UTC Replying to [ticket:2749 mwortmann]:

Wouldn't the simple (Settings > GRASS working environment > ) Change mapset dialog be a lot more useful in the Layer Manager toolbar? I'm not sure how many people are actually using the dialog, but I'm sure most use the commandline to do this simple change. I

I use the dialog quite often when I don't remember the mapset names.

always thought typing 'g.mapset xyz' (plus maybe g.mapset -l) or going to the dialog, seems too much for such a simple thing. The simple dropdown without the Ok button would be quick and easy. Plus it could show the current mapset which is somewhat missing in the Layer Manager.

I mostly agree but I am not sure where to put it, there is already a lot of things in the toolbar, so we would have to start a new row of toolbars? Maybe the data catalog tab would be an option?

BTW, on Ubuntu, you can type Alt and then 'Change ...' and launch the dialog in this way, too.

landam commented 5 years ago

Comment by mwortmann on 18 Sep 2015 13:19 UTC I had a little fiddle and copying the approach from the mapdisplay toolbox, adding the following lines to the LMWorkspaceToolbar _init method gives you an impression how it would look like:

        # add mapset selector
        self.combo = MapsetSelect(parent = self, id = wx.ID_ANY, size = (150, -1))
        self.comboid = self.AddControl(self.combo)
        self.parent.Bind(wx.EVT_COMBOBOX, self.OnChangeMapset, self.comboid)

I havent found a working way to for the self.OnChangeMapset method though. Regarding the size, I have two rows and neither of them is filled. Adding the 150px select combo fills out the top row nicely. I'm running the g.gui from a remote machine, so the Ubuntu shortcut doesnt work for me:$

landam commented 5 years ago

Comment by wenzeslaus on 18 Sep 2015 13:54 UTC Now I see what you mean. These combos in the toolbars mostly work but in general are best avoided, so I wouldn't add another one if not necessary. The Mapset name is in the Map Display window title, although in a cryptic way.

landam commented 5 years ago

Comment by mwortmann on 18 Sep 2015 15:47 UTC I agree that in the map display toolbox the combo box is a bit awkward, but I think for a potentially long list of mapsets this would be the most convenient way to change them. Putting a mapset changer a bit more prominent into the gui would also help newbies come to terms with the mapset idea and give them an incentive to use them. I know far too many people starting with grass that just dump all their maps into PERMANENT.

Re displaying the current mapset: The Map Display title doesnt update when you actually change the mapset, which makes it more confusing than helpful sometimes. I tweak my commandline prompter in my .grass.bashrc two have a constant reminder of where I am, which also updates. But there is nothing like that in the gui.

landam commented 5 years ago

Comment by wenzeslaus on 18 Sep 2015 17:44 UTC Replying to [comment:4 mwortmann]:

Re displaying the current mapset: The Map Display title doesnt update when you actually change the mapset, which makes it more confusing than helpful sometimes.

This is a clear bug or imperfection, please open another report for that. You can add your suggestion of formatting as well, unless you thing that the current one is ok.

landam commented 5 years ago

Comment by neteler on 5 May 2016 14:08 UTC Milestone renamed

landam commented 5 years ago

Comment by neteler on 28 Dec 2016 15:04 UTC Ticket retargeted after milestone closed

landam commented 5 years ago

Modified by @landam on 5 May 2017 20:40 UTC

landam commented 5 years ago

Comment by @landam on 1 Sep 2017 20:28 UTC All enhancement tickets should be assigned to 7.4 milestone.

landam commented 5 years ago

Comment by neteler on 26 Jan 2018 11:40 UTC Ticket retargeted after milestone closed

landam commented 5 years ago

Modified by neteler on 12 Jun 2018 20:48 UTC

landam commented 5 years ago

Comment by @landam on 25 Sep 2018 16:52 UTC All enhancement tickets should be assigned to 7.6 milestone.

landam commented 5 years ago

Comment by @landam on 25 Jan 2019 21:07 UTC Ticket retargeted after milestone closed