search

landam / grass-gis-git-migration-test

0 stars 0 forks source link

Set size in d.northarrow #219

Open landam opened 5 years ago

landam commented 5 years ago

Reported by wenzeslaus on 28 May 2016 13:46 UTC Size of the north arrow cannot be changed. All symbols are scaled to one common size, that's good, but this size should be further rescaled by a value of a size option.

GRASS GIS version and provenance

svn-trunk

Migrated-From: https://trac.osgeo.org/grass/ticket/3050

landam commented 5 years ago

Comment by lazaa on 2 Jun 2016 11:04 UTC Replying to [ticket:3050 wenzeslaus]:

Size of the north arrow cannot be changed. All symbols are scaled to one common size, that's good, but this size should be further rescaled by a value of a size option.

The size of symbol is manually tuned and for each symbol is quite different. I would add size option. If user doesn't use size manually tuned size will be used. But if user writes size=25 for some symbols it will have increasing size effect and for others decreasing size effect. Is it OK? User would have to find right size for a symbol and after that if he changed mind and wanted use another symbol he would have to find the right size one more time.

    /* sizes manually tuned */
    switch (n_arrow_num[0]) {
    case '7':
        symbol_size = 23.;
        break;
    case '8':
    case '9':
        symbol_size = 17.;
        break;
    case 'b':
        symbol_size = 80.;
        break;
    case 'f':
        symbol_size = 100.;
        break;
landam commented 5 years ago

Comment by wenzeslaus on 2 Jun 2016 19:51 UTC Replying to [comment:1 lazaa]:

Replying to [ticket:3050 wenzeslaus]:

All symbols are scaled to one common size, that's good, but this size should be further rescaled by a value of a size option.

If user doesn't use size manually tuned size will be used. But if user writes size=25 for some symbols it will have increasing size effect and for others decreasing size effect.

I don't know what is better if to scale, as I suggested, which is different behavior from all the other modules (so it might be better to call it scale), or if it is better to overwrite the size, as you suggest and consequently make it potentially harder for the user (symbols in d.vect behave the same but they have more similar sizes).

For now, I suggest to skip this issue.

landam commented 5 years ago

Comment by @landam on 27 Aug 2016 13:42 UTC Milestone renamed

landam commented 5 years ago

Comment by neteler on 26 Jan 2018 11:40 UTC Ticket retargeted after milestone closed

landam commented 5 years ago

Comment by @landam on 28 Feb 2018 20:08 UTC Can we close the issue?

landam commented 5 years ago

Comment by annakrat on 2 Mar 2018 15:18 UTC No, it's still valid problem. But I am not sure which is the right solution at this point.

landam commented 5 years ago

Modified by neteler on 12 Jun 2018 20:48 UTC

landam commented 5 years ago

Comment by @landam on 25 Sep 2018 16:53 UTC All enhancement tickets should be assigned to 7.6 milestone.

landam commented 5 years ago

Comment by @landam on 25 Jan 2019 21:08 UTC Ticket retargeted after milestone closed