search

landam / grass-gis-git-migration-test

0 stars 0 forks source link

patch proposal: do not show delimiters for empty labels in case of multiple cats per feature #22

Open landam opened 5 years ago

landam commented 5 years ago

Reported by mlennert on 18 Apr 2009 12:54 UTC The attached patch (against svn7) slightly modifies d.vect in that it only displays delimiters ("/") for those category values where label values actually exist. I attache two screenshots to make clearer what the patch does.

I would just submit the patch without posting, but I'm not sure if some people find it important to see the existance of null values for some categories. However, if no one objects, I'll commit.

Moritz

GRASS GIS version and provenance

svn-trunk

Migrated-From: https://trac.osgeo.org/grass/ticket/562

landam commented 5 years ago

Attachment from mlennert on 18 Apr 2009 12:54 UTC

https://trac.osgeo.org/grass/attachment/ticket/562/d.vect_attr.diff.gz

landam commented 5 years ago

Attachment from mlennert on 18 Apr 2009 12:55 UTC

https://trac.osgeo.org/grass/attachment/ticket/562/without_patch.png

landam commented 5 years ago

Attachment from mlennert on 18 Apr 2009 12:55 UTC

https://trac.osgeo.org/grass/attachment/ticket/562/with_patch.png

landam commented 5 years ago

Comment by hamish on 18 Apr 2009 15:01 UTC what's the command line option to do that? I'm not sure I know what that does.

my gut feeling is that those empty delimiters actually do show information: positional. if you remove them and only one field has a value, which field did it come from, a, b, or c?

Hamish

landam commented 5 years ago

Comment by dersh on 20 Apr 2009 05:23 UTC I think that it really depends on the data.
For example, if you were doing samples at several locations once a month, but a few of the actual samples got lost in processing, then I would say that you are correct that missing data should be shown.
On the other hand if the data is "missing" because it is the result of a query, ("select where value > 10" or "select where date < 2007-01-01") then you intentionally don't want to show some data, and having those slashes doesn't show any useful information. I would argue that if you actually are missing data, then it should be entered into the database as missing (-999, "M" whatever is appropriate for the type of data), rather then just leaving it blank.
Perhaps the best answer would be to a flag for which behavior is desired.

I would also propose that the user should be able to select what delimiter is used. "/" is not a bad choice for the default, but perhaps the user wants "\n" instead? That way the labels are not a cluttered in some cases. Another flag for d.vect?

landam commented 5 years ago

Modified by @landam on 12 May 2016 06:42 UTC

landam commented 5 years ago

Modified by @landam on 25 Aug 2016 15:51 UTC

landam commented 5 years ago

Comment by @landam on 27 Aug 2016 13:42 UTC Milestone renamed

landam commented 5 years ago

Comment by neteler on 26 Jan 2018 11:40 UTC Ticket retargeted after milestone closed

landam commented 5 years ago

Modified by neteler on 12 Jun 2018 20:48 UTC

landam commented 5 years ago

Comment by @landam on 25 Sep 2018 16:51 UTC All enhancement tickets should be assigned to 7.6 milestone.

landam commented 5 years ago

Comment by @landam on 25 Jan 2019 21:07 UTC Ticket retargeted after milestone closed