landgreen / n-gon

2-d physics rogue-lite platformer shooter
https://landgreen.github.io/n-gon/
GNU General Public License v3.0
163 stars 235 forks source link

broken clock map. #108

Closed Loiccoder closed 1 year ago

Loiccoder commented 1 year ago

This is my first issue report but i have encountered it a few amount of times (more than one) and it completely throws a game i was playing on experiment mode having fun, and then it loaded clock map. but inmediately as i spawned in, it was all buggy and has no collision. I will provide as much information as i can. I do not remember the name of the map i was playing before, but at first sight it was like the previous map fused into clock.

Screenshot 2023-10-31 at 3 42 59 PM Screenshot 2023-10-31 at 3 43 13 PM

hope the images work.

the dark gray objects dont have collision, and i spawn with and endless loop of falling to the void, which forced me to get into testing. ignore the blocks i am standing on and the weird blocks on the "trap" room. i added them myself in testing. I will provide more info

Screenshot 2023-10-31 at 3 44 34 PM

thanks for teaching me how to look at console btw. more info: banned maps: dojo, yingYang, stereoMadness, tlinat, staircase, ruins, ace, cantilever, superNgonBros. ( if landgreen is interested on why i banned them, i would love to discuss it.) seed: 74886 build url (pretty fun) i am playing on safari (i recognize its buggy) I dont know what im doing.

Loiccoder commented 1 year ago

forgot to say that as i started taking screenshots the dark gray elements of the previous map dissappeard, i dont know how. but they are not here anymore, the only thing remaining is the slime. im pretty sure at the start clock was missing dark gray sections, but then it swapped. also a few mobs spawned and the physics on the gears still work. edit: i managed to replicate the bug.

kgurchiek commented 1 year ago

Thanks for reporting it, I'll work on fixing it

landgreen commented 1 year ago

I see the fix in the pull requests. I don't understand the issue, but I can put that fix in the next patch.

kgurchiek commented 1 year ago

The issue is that array.splice actually affects the original array instead of just returning a new one, so the map would mess up the boss spawning list

landgreen commented 1 year ago

oh cool, so maybe that solves the other pending issue: "Issue with boss spawning"

kgurchiek commented 1 year ago

Yeah I'm pretty sure that's what the issue was, since they had community maps enabled