github pages trouble

[AnnonymousNerd87]

I recently forked n-gon and made a few dumb changes (the physics for some stuff is different), while removing some smart ones (ammo management, death), and everything was running smoothly. I had made a github pages page (?) and it had worked before, but after committing the changes and waiting for the upload the github pages link went down for a while, then when it came back up only the index.html loaded, so when I tried to start the game nothing happened. I didn't even touch the index.html until then so I don't know what went wrong. Here is the link to the repo: https://github.com/AnnonymousNerd87/AnnonymousNerd87.github.io I have already invited you as a collaborator so we can try to fix it.

not expecting a response soon, I know school days aren't the best time.

[landgreen]

The first thing I notice is that you don't have a player.js file

[kgurchiek]

I think the issue is the extra closing bracket on line 424 of player.js

[AnnonymousNerd87]

I have a player.js file, I just updated it a bit.

[AnnonymousNerd87]

I can restore it now, see if it helps

[kgurchiek]

There's a syntax error in your modified player.js preventing it from running

[landgreen]

Where is your player.js file? (I'm in github pages)

[kgurchiek]

@landgreen it isn't loading due to a syntax error, but it does exist https://github.com/AnnonymousNerd87/AnnonymousNerd87.github.io/blob/master/js/player.js

[AnnonymousNerd87]

I just restored the wipe canvas function I accidentally deleted, testing now

[AnnonymousNerd87]

nope, still not working

[AnnonymousNerd87]

let me revert the whole player.js file to an original version

[AnnonymousNerd87]

I didn't make too much edits in my version, so it should help

[landgreen]

@landgreen it isn't loading due to a syntax error, but it does exist https://github.com/AnnonymousNerd87/AnnonymousNerd87.github.io/blob/master/js/player.js

Oh so if you have a syntax error it's hidden in dev tools? I didn't know that.

[kgurchiek]

Yeah, if scripts fail to run it won't show them in the sources tab

[AnnonymousNerd87]

I just fixed the syntax error, saving now

[AnnonymousNerd87]

it works!

[AnnonymousNerd87]

thanks landgreen and kgurchiek, I hadn't noticed the syntax error

[AnnonymousNerd87]

this saved me a lot of trouble

[AnnonymousNerd87]

Screen recording 2024-04-20 11.04.46 AM.webm

[AnnonymousNerd87]

man I love indie devs