search

landgreen / n-gon

2-d physics rogue-lite platformer shooter
https://landgreen.github.io/n-gon/
GNU General Public License v3.0
134 stars 193 forks source link

Hilbert space bug #227

Closed Masbirb closed 2 months ago

Masbirb commented 2 months ago

After removing Hilbert space the effect is removed as normal but not the appearance of M

AnnonymousNerd87 commented 2 months ago

why would anyone remove Hilbert space, you monster

AnnonymousNerd87 commented 2 months ago

/hj

Masbirb commented 2 months ago

Brainstorming accident

AnnonymousNerd87 commented 2 months ago

still

On Mon, Apr 29, 2024 at 3:35 PM Mason Finch @.***> wrote:

Brainstorming accident

— Reply to this email directly, view it on GitHub https://github.com/landgreen/n-gon/issues/227#issuecomment-2083802817, or unsubscribe https://github.com/notifications/unsubscribe-auth/BHEAKNAPPEMJMDFQTSQRLADY73DKZAVCNFSM6AAAAABG7END6CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBTHAYDEOBRG4 . You are receiving this because you commented.Message ID: @.***>

3xionDev commented 2 months ago

that's just a missing line of code, lemme see if I can find it. it should be the line that updates the player's appearance after getting/removing a SKINtech.

3xionDev commented 2 months ago

found it. the remove() { function for Hilbert Space is missing the following line:

            if (this.count) m.resetSkin();

or something similar to this. it definitely involves m.resetSkin(), unless anodize() uses a different method.

landgreen commented 2 months ago

fixed, thanks