landgreen / n-gon

2-d physics rogue-lite platformer shooter
https://landgreen.github.io/n-gon/
GNU General Public License v3.0
134 stars 193 forks source link

Newtons 1st Law.webp not showing up in web page, but showing up everywhere else #253

Closed landgreen closed 1 month ago

landgreen commented 1 month ago

I can't figure this one out.

Newtons 1st Law.webp the image exists in the landgreen github repo https://github.com/landgreen/landgreen.github.io/blob/master/n-gon/img/Newtons%201st%20Law.webp I can also see the image on my local version version of n-gon, but it's missing when I goto the web page.

Screenshot 2024-05-11 at 3 04 58 PM Screenshot 2024-05-11 at 3 05 12 PM
3xionDev commented 1 month ago

I think that's just from the GitHub pages server failing to fetch the image. I don't know why it wouldn't show the unavailable image icon though. it's possible that it's outscaling the image out of the container and that's hiding the icon, but that's a bit far-fetched. either way, this has happened to me before, and it's usually something that just resolves itself, at least for me.

3xionDev commented 1 month ago

that would also explain why it's working on your local copy, since it's not using github cdn to fetch the images but instead fetching them directly from the file.

kgurchiek commented 1 month ago

every time I play I always notice it logs that it failed to fetch the newton's 1st law image, maybe it's a github bug?

creator1116 commented 1 month ago

have you tried downloading the zip and playing from a local file

AnnonymousNerd87 commented 1 month ago

tons of images don't load for me, but I have a firewall which blocks the dictionary of obscure sorrows, so its prob. on my end for those

3xionDev commented 1 month ago

yes, I believe it's a github CDN issue

AnnonymousNerd87 commented 1 month ago

maybe it's something dumb like a syntax error, I don't know how common those are for js bc I'm not as experienced in js as c but in unity I was so confused with my syntax errors in unity. not saying I think you make syntax errors very often, your code is very neat and tidy, landgreen!

3xionDev commented 1 month ago

I already checked, it's not a syntax error. Everything is written fine. Once again, this is most likely a CDN issue on github's side of things.

4kh00 commented 1 month ago

https://landgreen.github.io/n-gon/img/Newtons%201st%20law.webp is a 404 error.

kgurchiek commented 1 month ago

Yeah, that means it's an issue on Github's end, there's nothing wrong with the code

3xionDev commented 1 month ago

shall we close?

kgurchiek commented 1 month ago

@landgreen have you tried deleting it and uploading again?

landgreen commented 1 month ago

Deleting it and uploading didn't work. My current theory is that the image had a flaw that upset the server. Some images are just evil. So I plan to make a new image and upload it.

AnnonymousNerd87 commented 1 month ago

"Some images are just evil" XD

On Thu, May 30, 2024 at 9:29 PM landgreen @.***> wrote:

Deleting it and uploading didn't work. My current theory is that the image had a flaw that upset the server. Some images are just evil. So I plan to make a new image and upload it.

— Reply to this email directly, view it on GitHub https://github.com/landgreen/n-gon/issues/253#issuecomment-2141212797, or unsubscribe https://github.com/notifications/unsubscribe-auth/BHEAKNAN6WMVZZ2CQWVELLLZE74BZAVCNFSM6AAAAABHSHW4ICVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBRGIYTENZZG4 . You are receiving this because you commented.Message ID: @.***>

landgreen commented 1 month ago

well I uploaded a completely new image and the issue persists. So, my "evil images" theory is probably wrong. I'll try renaming the tech next.

update tech rename worked