search

landgreen / physics

Explorable Physics is a website with course notes for algebra based physics with explorable explanations.
https://landgreen.github.io/physics/index.html
GNU General Public License v3.0
128 stars 14 forks source link

Translates #18

Closed Agzam4 closed 1 year ago

Agzam4 commented 2 years ago

Try: https://agzam4.github.io/physics-ru/ Issue | Can it be translated into Russian #17

index.html now is en.html

To add new language to page:

In index.html:

...
<body>
    <a id="en" href="en.html">en</a>
    <!-- Add Languages here: -->
    <a id="ru" href="ru.html">ru</a>
</body>
...

In langs.js:

const SELECT_TAG = "select";
const OPTION_TAG = "option";

window.onload = function() {
    let langs = ["en", "ru"]; // <- Add Languages here
        ...
landgreen commented 2 years ago

oh wow, this looks great! (sorry I don't check github much, so I just noticed your pull request a few minutes ago)

I'm thinking the best thing right now is for me to just put a link to your Russian version github instead of the the drop down menu. It seems like the experience will be cleaner to have two different pages. Also that would let you set your page to Russian as a default in the drop down menu.

Does that make sense to you? A link on my physics home page to your hosted github and you can keep your version as full Russian? https://agzam4.github.io/physics-ru/en.html

landgreen commented 2 years ago

I was just thinking more on this. I'll probably make some major changes to the layout if I start teaching new content, and I don't want to break your translation. So I think 2 separate versions, Russian and English makes the most sense.

Agzam4 commented 2 years ago

I was just thinking more on this. I'll probably make some major changes to the layout if I start teaching new content, and I don't want to break your translation. So I think 2 separate versions, Russian and English makes the most sense.

I am satisfied with both options, your option is the most convenient for translation, my option allows you to add translations to other languages