search

landlock-lsm / rust-landlock

A Rust library for the Linux Landlock sandboxing feature
https://crates.io/crates/landlock
Other
88 stars 9 forks source link

Avoid actions from actions-rs #31

Closed bjorn3 closed 1 year ago

bjorn3 commented 1 year ago

They aren't maintained all that well from what I can tell. In addition this reduces the risk of issues due to buggy updates. Supply chain attacks have already been mitigated using the permissions: {} key.

Signed-off-by: Björn Roy Baron bjorn3_gh@protonmail.com

l0kod commented 1 year ago

I just splitted the && commands in two lines. Because by default GitHub actions use set -e, this is a pure cosmetic change.

l0kod commented 1 year ago

I wrapped all cargo commands with rustup run stable to make sure we know which one is used whatever $PATH. It was also needed to manually remove cargo-fmt files to avoid these kind of (legitimate) warnings:

warning: tool `rustfmt` is already installed, remove it from `/home/runner/.cargo/bin`, then run `rustup update` to have rustup manage this tool.
warning: tool `cargo-fmt` is already installed, remove it from `/home/runner/.cargo/bin`, then run `rustup update` to have rustup manage this tool.

The rustup default stable is now not strictly needed but I kept it as a safeguard.

l0kod commented 1 year ago

I also applied these changes to pages.yml

bjorn3 commented 1 year ago

All changes make sense to me. Maybe add yourself as Co-Authored-By?

l0kod commented 1 year ago

All changes make sense to me. Maybe add yourself as Co-Authored-By?

OK, I didn't know GitHub supported this trailer. Thanks!