search

landlockedboat / atom-contrib-rocket

Atom package that displays contrib-rocket in your status bar.
https://github.com/wextia/atom-contrib-rocket
MIT License
2 stars 2 forks source link

npm, gh-contribs, spark, not found #1

Open dasilvacontin opened 7 years ago

dasilvacontin commented 7 years ago

screen shot 2017-02-12 at 8 08 50 pm

It's stuck there for me.

execContribRocket is getting executed with:

[null, "Using npm to install gh-contribs (contrib-rocket's dependency)
Using curl+chmod to install spark (contrib-rocket's dependency)
🚀
", "/Users/dasilvacontin/github/dasilvacontin/dotfiles/.atom/packages/atom-contrib-rocket/node_modules/contrib-rocket/contrib-rocket.sh: line 18: npm: command not found
sudo: no tty present and no askpass program specified
/Users/dasilvacontin/github/dasilvacontin/dotfiles/.atom/packages/atom-contrib-rocket/node_modules/contrib-rocket/contrib-rocket.sh: line 4: gh-contribs: command not found
/Users/dasilvacontin/github/dasilvacontin/dotfiles/.atom/packages/atom-contrib-rocket/node_modules/contrib-rocket/contrib-rocket.sh: line 4: spark: command not found
"]

Apparently it's a bug in OSX where, if you don't launch Atom from the terminal, it doesn't correctly inherit the $PATH env var (therefore it cannot find any of those binaries when running contrib-rocket).

Potential fix by using sindresorhus/fix-path, gonna give it a shot.

dasilvacontin commented 7 years ago

fixPath is not an acceptable solution. Probably the user needs to fix their PATH in Atom. But we should let them know what's the problem and what's the fix.