lando / acquia

The Official Acquia Lando Plugin
https://docs.lando.dev/acquia
GNU General Public License v3.0
2 stars 6 forks source link

`lando pull` should pass in flags to acli, at the least the `--on-demand` flag #73

Closed nalipaz closed 6 months ago

nalipaz commented 6 months ago

The lando pull command works great but it seems that it doesn't pass in flags that are available. Due to the output provided by acli it is seemingly confusing why the flags passed in won't work as well.

% lando pull
If you would like to customize the behavior of this message then check out:
https://docs.lando.dev/config/releases.html
? Pull code from? none
? Pull database from? Dev, dev (vcs: pipelines-build-development)
? Pull files from? Dev, dev (vcs: pipelines-build-development)
--
The following Cloud Platform API key is active:....

 [INFO] Using a database backup that is 21 hours old. Backup #269581476 was created at Fri Dec 21 3:47:05 UTC 2023.      

        You can view your backups here: https://cloud.acquia.com/a/environments/.../databases

        To generate a new backup, re-run this command with the --on-demand option.

As seen here the acli command outputs the detail about the --on-demand flag. That said, it was a bit confusing at first when that flag had no affect on the command. I realized however and would like to request that we be able to pass in that flag to lando pull and it will subsequently pass it into acli.

nalipaz commented 6 months ago

Closing in favor of #74