lando / core-next

Next generation Lando v4 runtime
https://docs.lando.dev/v/next
GNU General Public License v3.0
4 stars 4 forks source link

Simpler, more professional console messages #64

Open gaelanlloyd opened 2 years ago

gaelanlloyd commented 2 years ago

Awesome project, Lando team!

The console messages are fun and cute, but after a while the ASCII art takes up a lot of space and are a distraction.

In line with lando/lando#1726, is there a way to make the messages simpler and more professional?

For instance, when shutting down:

% lando poweroff

NO!! SHUT IT ALL DOWN!!!
   ___                     _                  ______
  / _ \___ _    _____ ____(_)__  ___ _  ___  / _/ _/
 / ___/ _ \ |/|/ / -_) __/ / _ \/ _ `/ / _ \/ _/ _/ _ _
/_/   \___/__,__/\__/_/ /_/_//_/\_, /  \___/_//_/(_|_|_)
                               /___/

Bye bye landoproxyhyperion5000gandalfedition_proxy_1 ...
Bye bye mylandoapp_database_1 ...
Bye bye mylandoapp_appserver_1 ...
Lando containers have been spun down.

Could be simplified and cleaned up to be:

% lando poweroff

Shutting down Lando containers:
  - landoproxyhyperion5000gandalfedition_proxy_1 ...
  - mylandoapp_database_1 ...
  - mylandoapp_appserver_1 ...
Done

I'm thinking there could be an advanced mode that quietly closes the containers, listing them only if there's an error.

% lando poweroff
Shutting down Lando containers... Done

There could even be a PRO mode that is silent unless there are errors. The idea here is that we just trust Lando to do its job and don't need to know all of the details unless we specify that we want the added verbosity.

% lando poweroff
%

I'm not sure if logLevelConsole affects this, I can't really find any documentation on what it does or what the various settings are other than setting it to silly in this example.

It would be nice if this was a setting in the global Lando config so it would apply to all Lando commands in a user's environment.

reynoldsalec commented 2 years ago

There have been a few varying requests over time to give options to "tone down" the messages. Lando is looking at switching to a new CLI tooling (https://oclif.io/), which may make it easier to accomplish this, although it's probably a low priority compared to many of the other 4.x roadmap items.

I think this may be a duplicate of a previous issue but I couldn't find one, so going to keep this open for now with the 4.x reminder label.

trackleft commented 2 years ago

One could argue that these giant messages are actually useful when scrolling through your history and visually break up the commands you have run.

reynoldsalec commented 2 years ago

Yeah, I personally like the BIG messages, both to break up output and also for their aesthetics (gives me that cyberpunk vibe that I'm looking for sometimes).

If someone ever gets the chance to tackle this, I think having a setting (corporatemode? buttondown?) that would manipulate output to satisfy the bossman would be good.

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions and please check out this if you are wondering why we auto close issues.

stebogit commented 7 months ago

I would argue that less verbose messages would be convenient when you want to run multiple applications at the same time. Same goes with URL scanner and health check tools/messages.

The more Lando matures the less verbosity is necessary and once the environment for your project is set up correctly I think verbosity becomes noise, so I do see the need of a --silent or --quiet flag when running "everyday use" commands like start and poweroff

I do support the large and colorful font in the messages though.

pirog commented 7 months ago

@stebogit i think this ticket is more about the style and theme of the output and less about the verbosity of them

stebogit commented 7 months ago

yeah maybe you're right; what I had in mind was an additional flag, something like

$ lando poweroff --quiet
Shutting down myapp... Done
$ lando poweroff --silent
$

and

$ lando start --quiet
Starting myapp... Started!
$ lando start --silent
$

Maybe a different issue then?

pirog commented 7 months ago

@stebogit yeah i would open another ticket for that in https://github.com/lando/core-next and im also going to move this one over there because both of these are def lando 4 things.

i also would say that im open to --silent, assuming that its purpose is to suppress output completely but the case would have to be pretty compelling given that a user can do this on their own with redirects, pipes, etc.

im less open to --quiet assuming it means "less output" because its not obvious to me WHAT should be suppressed and it feels pretty gross to me to have both --silent and --quiet.

in my ideal world and in lando 4 we just have better output so --quiet isnt even something we feel we need and --silent maybe is covered by one of the "languages" we plan on supporting that you could switch to.