lando / core

Current Lando v3 runtime
https://docs.lando.dev/core/v3
GNU General Public License v3.0
9 stars 21 forks source link

OrbStack not working with Lando. #138

Open Vinsanity opened 6 months ago

Vinsanity commented 6 months ago

Hello Lando team!

I've discovered what I think is a bug that I reported to OrbStack but they discovered and pointed out an interesting find in the Lando daemon.js.

It appears that it's hardcoded to look for the Docker app when trying to read info.

I was getting errors for Cannot read properties of null (reading 'trim') until I installed the Docker desktop app. After I installed that, I ran it once and shut it down. Booted up OrbStack again and Lando was working again.

Could you add a prompt for that when a Lando project spins up for the first time? Or maybe allowing it to be defined in a yml config?

pirog commented 5 months ago

@Vinsanity Lando does not currently support OrbStack so this makes sense. Lando 4 will allow for the kind of configuration you mention.

arzola commented 3 months ago

Well at this point works very well with Orbstack the only downside is that the Docker App should be installed but not turned on just to bypass that daemon.js check

maxfenton commented 1 month ago

+1 for bypassing this check and making way for Orbstack

Please consider updating the Mac install section of the Lando docs to explain that Docker Desktop for Mac must be installed and have run once (but does not need to be running after that) to allow lando start to work