search

lando / core

Current Lando v3 runtime
https://docs.lando.dev/core/v3
GNU General Public License v3.0
9 stars 22 forks source link

Update scanner from 25 retries to 5 #200

Open millnut opened 1 week ago

millnut commented 1 week ago

25 retries seems very excessive, most services tend to retry up to 5 times. Updating a lot of lando projects from 25 to 5 is very time consuming.

It would be great if the default was changed to check 5 times.

pirog commented 1 week ago

I don't understand this request.

The retries will not continue once any one scan completes with success or failure. So if your app only takes 5 tries to return such a code then its not going to do the 20 other retries eg for all intents and purposes if your app only takes 5 times to retry this is already doing what you want.

Also note that this scan is not for a "service" to start up its for a URL in an app to be scanned and a valid status code to be returned. There are A LOT of bad, bloated apps out there that are not going to report back a status in only 5 retries so "most services tend to retry up to 5 times" is probably not true. There are also "good" apps on slower machines that may need more scans.

Regardless, the max amount of scans should give the overwhelming majority (eg 90%+) of apps the opportunity to return a status code and im doubtful that 5 accomplishes this.