Path is undefined error when using tilde expansion in plugin path

lando / core

Current Lando v3 runtime

https://docs.lando.dev/core/v3

GNU General Public License v3.0

9 stars 21 forks source link

Path is undefined error when using tilde expansion in plugin path #207

Open AaronFeledy opened 3 weeks ago

AaronFeledy commented 3 weeks ago

😊:

plugins:
  'icanhaz/lolcats': '/home/moot/projects/lolcats'

🤮:

plugins:
  'icanhaz/lolcats': '~/projects/lolcats'

Did a quick pass with the debugger and it looks like during init of the plugin class, if the path has the tilde, the string ends up in the version field of the plugin class, instead of in the directory field. So, later down the line when directory is passed to some method's path parameter, Lando pukes backtrace.

reynoldsalec commented 1 week ago

I don't think we've really supported the ~ in most cases...I know I've had to custom-implement support for some of my plugins if I wanted it, so I'm assuming core doesn't as well. Not sure if there's a theory behind why it's not supported. Perhaps a good v4 goal?