lando / docs

The main docs site for Lando
https://docs.lando.dev/
GNU General Public License v3.0
19 stars 55 forks source link

Document inability to override arrays in landofiles #1

Open jdleonard opened 4 years ago

jdleonard commented 4 years ago

Please complete the following:

Link to the page that needs to be updated or changed. https://docs.lando.dev/config/lando.html

Describe the change you'd like It would be helpful for any limitations to the ability to override landofiles to be spelled out. For example, if I have this in lando.yml:

services:
  appserver:
    run:
      - command1
      - command2

and this in lando.local.yml:

services:
  appserver:
    run:
      - command3
      - command4

I would expect only command3 and command4 to run, but all four commands are running.

@dustinleblanc said

I think we’re using _.merge to merge the data objects together, and I bet it just concats arrays

I'm not sure whether this is a bug or a documentation need.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions and please check out this if you are wondering why we auto close issues.

arjona commented 2 years ago

I've also run into this issue with the proxy subdomain configs. I'm trying to spin up a 2nd instance of the app to diagnose a particular issue. When I lando start I see both the original and overriden proxy configurations bound as endpoints for my app like:

http://localhost:12345/ http://*.myapp.lndo.site/ https://*.myapp.lndo.site/ http://*.myapp-issue-123.lndo.site/ https://*.myapp-issue-123.lndo.site/

Is there any other mechanism I could use to override the subdomain config? All I really want is a variable of some sort so I can plug in the app name and I wouldn't need overrides.

if I could say proxy: appserver:

that would be ideal as then the only thing that needs to be overriden in the local lando file is the app name.

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions and please check out this if you are wondering why we auto close issues.