search

lando / drupal

The Official Drupal Lando plugin
https://docs.lando.dev/drupal
GNU General Public License v3.0
16 stars 16 forks source link

Support 10.1 lazy aggregation #48

Closed neclimdul closed 1 year ago

neclimdul commented 1 year ago

This adds support for Drupal's updated CSS and JavaScript aggregation .

netlify[bot] commented 1 year ago

Deploy request for lando-drupal accepted.

Name Link
Latest commit 0da201a851e4c1b6d2e56ad56b0feac054cd5c32
Latest deploy log https://app.netlify.com/sites/lando-drupal/deploys/63dd2c6dae13730009d503a9
neclimdul commented 1 year ago

This is pretty easy to test. checkout the latest 10.1.x branch of Drupal core, add a basic D10 lando setup, install the site.

As soon as the site is finished installing you'll be greeted with a site that has not styles. inspecting the network tab you'll see 404's for all the css/js requests to the aggregated urls.

Notes: 1) This is the exact change from the change log but there was some discussion in the Drupal slack if it made sense for development systems like ddev and lando to just have the sites/*/files/ fallback on core to support any other modules that have lazy handlers. :shrug: 2) It might make sense to backport this to D9 recipe in case people like me are jumping back and forth between d10 and d9 and have the d9 recipe in their lando config while working on migration/updates.