Closed cboyden closed 5 years ago
try ./docker-compose.yml
@jbertoen I get the same results when referencing ./docker-compose.yml
instead of docker-compose.yml
. If I run lando start
from below the root directory, the chromedriver service on the container is either not started or not accessible.
Yeah that does seem like a bug, think I found it as well: plugins/lando-app/index.js, line 129:
// Validate files
var files = utils.validateFiles(_.get(app, 'config.compose', [], root));
If you dissect this utils.validateFiles(); would be called with only one parameter. Which would be the result of _.get(app, 'config.compose', [], root); The bug here is that _get() only has 3 parameters, and it is called with 4. And validateFiles() should be called with 2 parameters, and is called with 1. The second parameter of validateFiles() would be root. So it appears that there is a small typo here.
This might be the fix. Maybe @pirog or @dustinleblanc have an opinion about this?
// Validate files
var files = utils.validateFiles(_.get(app, 'config.compose', []), root);
Got a PR waiting for test results. Hopefully this would fix the issue. @cboyden could you try to use this branch of mine as a source for you lando setup and try if it works? To do that read this: https://docs.devwithlando.io/installation/installing.html#from-source Instead of using the lando/lando repo, use mine from the PR 😄
Any updates on this? Just ran into this issue today myself and it would be good to fix since with the drupal7 recipe one must be in the webroot (below the app root where .lando.yml is) to run drush commands.
This should be fixed in the forthcoming RC2
When I run
lando start
from a level below the project root, the container I've configured in my docker-compose.yml either doesn't start or isn't accessible to Lando.Tell us about your setup
v3.0.0-beta.46 on Mac OSX 10.13.4
Tell us about your
.lando.yml
docker-compose.yml (stored in project root, same level as .lando.yml)
Tell us about the command you were running
Tell us generally about your bug
Should Lando be able to find the
docker-compose.yml
file relative to the.lando.yml
file, rather than relative to where you run the start command? It's defined in the.lando.yml
file. Or is there a way to write the.lando.yml
file to force looking fordocker-compose.yml
relative to the project root?