Closed acrosman closed 5 years ago
@acrosman We have people (including folks on the team here at Tandem) using the web docroot feature with Pantheon, so I don't think an 'always fails' situation would be the case here. Just to doublecheck, have you tried a lando rebuild
? Was the site docroot modified at all since you initialized the app?
I was about to update this as well because it's not a 100% failure situation. Over the weekend I tried to restart the project from scratch to see if I took a misstep along the way. I deleted all the files, and reloaded, which resulted in Docker losing the file share between OSes for some reason. That led me to do a destroy
and then start
, and after fighting through getting it to accept the machine token the rebuilt machine came up working this morning and now things appear to be working.
I did not change the pantheon.yml
file so it appears something didn't setup right the first time, but I'm struggling to figure out what I did that might either be unusual enough to be a missing test case. It might be as simple as more instructions around rebuilding when the docroot changes (that might have gotten me to rebuild earlier even though I don't think that was my use case).
I was having this error destroyed and rebuilt multiple times. It was lando restart that fixed this for me. I guess I should have restarted it before rebuilding it over and over again. XD
We've got a test to verify the webroot setting is not ignored so going to close this out now https://github.com/lando/lando/tree/master/examples/pantheon
will be in the RC2
Bug Report
The FASTEST way for us to verify and resolve your bug if for you to write a functional test that breaks and submit it as a pull request.
If you are not sure how to do that then please complete as much of the below section as possible
Tell us about your setup
What is your lando version and operating system? (note that the older your version the less likely we are to reply) v3.0.0-rc1 on Windows 10 Professional
Tell us about your
.lando.yml
Pantheon.yml file:
Tell us about the command you were running
lando pull --files=dev --code=none --database=none
Tell us about the error you got The rsync will start up, but it cannot sync the files because it attempts to place the files in the app root instead of the web root. Database works fine, I haven't tried code but I expect it would fail.
Rerun the command that produced your error in
verbose
mode. Note thatverbose
mode is run like thislando command -- -vvv
. Paste in the error and the ~100 lines that proceeded it.Tell us generally about your bug
I was looking through the documentation on pull and noticed the
lando ssh -c "mkdir -p \$LANDO_WEBROOT/\$FILEMOUNT"
so I logged into the container and confirmed that$LANDO_WEBROOT
is/app
not/app/web
.I wondered where that got loaded and set and started to review the pantheon recipe JS file and noticed that the configuration appears to be loaded into
build
but webroot is defined outside that object and always returns false: https://github.com/lando/lando/blob/v3.0.0-rc.1/plugins/lando-recipes/recipes/pantheon/pantheon.js#L640I may be off track here, but it seemed like a place to start.