lando / laravel

The Official Laravel Lando Plugin
https://docs.lando.dev/laravel/
GNU General Public License v3.0
15 stars 11 forks source link

Lando scanners scans .lndo.site urls which are not in config #67

Open eldair opened 2 weeks ago

eldair commented 2 weeks ago

When using lando start scanner starts scanning .lndo.site url for my site but it is not enabled or written anywhere in the config file. This started happening week or two ago.

image image

AaronFeledy commented 2 weeks ago

The laravel recipe provides the lndo.site URLs by default. There was a bug that caused custom proxy config to overwrite these URLs rather than add to them. So, because you had a custom proxy config set, you were seeing the buggy behavior where the default URLs were not present. The bug was fixed in a recent release of the laravel plugin, so that's likely why you now see the default URLs when you hadn't before.

eldair commented 2 weeks ago

Interesting, so how I disable them? :D didn't see anything in the docs

reynoldsalec commented 2 weeks ago

Ironically, there's not really a way to remove the default *.lndo.site URLs in the Landofile...you'd have to customize the Lando Laravel plugin to do it. So the "bug" in the Laravel plugin was actually a feature for you ;)

Is there a reason having those URLs is a problem?

eldair commented 2 weeks ago

In that case I prefer the bugged version 😄 Jokes aside, I don't use them and the real issue is the scanner taking a lot of time scanning those urls which are not setup so they're returning error for every test

reynoldsalec commented 2 weeks ago

@eldair in that case you could just disable the scanner: https://docs.lando.dev/core/v3/scanner.html#skipping

eldair commented 2 weeks ago

@reynoldsalec yeah, that is a good temp solution but won't that disable all scanners - even for my own urls?

reynoldsalec commented 2 weeks ago

Correct @eldair; I think the alternative would be to configure your app to use the *.lndo.site URLs. In my experience it's rare to have a local site need to have a specific URL, but realize that exceptions exist.