search

lando / mariadb

The Official MariaDB Lando Plugin
https://docs.lando.dev/mariadb
GNU General Public License v3.0
0 stars 7 forks source link

Better Healthcheck Testing/Blank dbname/user Testing #44

Open reynoldsalec opened 6 months ago

reynoldsalec commented 6 months ago

We just implemented a fix to handle situations where the user specifies blank dbname/password/username for the db config. Ex:

services:
  database:
    type: mariadb
      creds:
        user: customusername
        password:
        database: customdbname

The fix: https://github.com/lando/mariadb/commit/017dba9545e3f7966ea16aad7e0256a71bee1fc5

I put in a "test case" in the custom example to make sure a blank password wouldn't fail the healthcheck or otherwise create problems, however, I'm not testing blank user or database values. From some quick manual testing it looked like those worked ok, but would be good to explicitly test this.