Add v11.4 to supported versions

lando / mariadb

The Official MariaDB Lando Plugin

https://docs.lando.dev/mariadb

GNU General Public License v3.0

0 stars 7 forks source link

Add v11.4 to supported versions #60

Open mortona42 opened 1 month ago

mortona42 commented 1 month ago

Added 11.4

Closes #59

Bare minimum self-checks

What do you think of a person who only does the bare minimum?

[X] I've updated this PR with the latest code from main
[?] I've done a cursory QA pass of my code locally
[?] I've ensured all automated status check and tests pass
[X] I've connected this PR to an issue

Pieces of flare

[ ] I've written a unit or functional test for my code
[ ] I've updated relevant documentation it my code changes it
[ ] I've updated this repo's README if my code changes it
[ ] I've updated this repo's CHANGELOG with my change unless its a trivial change (like updating a typo in the docs)

Finally

[ ] I've requested a review with relevant people

If you have any issues or need help please join the #contributors channel in the Lando slack and someone will gladly help you out!

You can also check out the coder guide.

netlify[bot] commented 1 month ago

Deploy request for lando-mariadb pending review.

Visit the deploys page to approve it

Name	Link
Latest commit	33f772170b58a9e5c517874b53546d0110bd3357

reynoldsalec commented 1 month ago

Tests are erroring out asking for the node service when setting up Lando; should be unrelated to this PR. Possible it's an issue with the latest lando-dev-slim? Might deserve testing out some PRs on other plugins and see if they have the same problem.

For this PR, we should add a 11.4 test to the suite and update the docs to reflect the new version being available.

AaronFeledy commented 1 month ago

Yeah, others are seeing Lando fail in GHA as well: lando/setup-lando#50

reynoldsalec commented 1 month ago

Thanks for the reference @AaronFeledy. Looks like a couple things are going on; first error appears to occur on running lando version on https://github.com/lando/setup-lando/blob/2aebacd1f41b906c82b2c2d5f3e326fc0a4b8bfe/setup-lando.js#L130.

For some reason it thinks the node Lando plugin should be installed...looks like Lando is bootstrapping with the .lando.yml that's at the root of the mariadb project when running lando version and that's causing that immediate error.

I made a semi-bogus .lando.yml to replace that with and now I'm getting past that error to see one that seems to indicate it's unable to find docker-compose, which sounds like it may be related to https://github.com/lando/setup-lando/issues/50