lando / node

The Official Node Lando plugin.
https://docs.lando.dev/node
GNU General Public License v3.0
2 stars 2 forks source link

Node version 20 is not supported #66

Closed cawa-93 closed 3 months ago

cawa-93 commented 5 months ago

When I try to start lando Displays an error that version 20 is not supported, despite the fact that the documentation states that version 20 is supported

https://github.com/lando/node/blob/2efe15ef228488644adee8f803844438ac5b2fa6/docs/index.md?plain=1#L20-L22

Unhandled rejection Error: node version 20 is not supported
    at new LandoLando (/snapshot/cli/node_modules/@lando/core/plugins/lando-core/builders/_lando.js)
    at new LandoAppserver (/snapshot/cli/node_modules/@lando/core/plugins/lando-core/builders/_appserver.js)
    at new LandoNode (/snapshot/cli/node_modules/@lando/node/services/node/builder.js)
    at /snapshot/cli/node_modules/@lando/core/plugins/lando-services/app.js
    at arrayEach (/snapshot/cli/node_modules/@lando/core/node_modules/lodash/lodash.js)
    at Function.forEach (/snapshot/cli/node_modules/@lando/core/node_modules/lodash/lodash.js)
    at AsyncEvents.<anonymous> (/snapshot/cli/node_modules/@lando/core/plugins/lando-services/app.js)
    at AsyncEvents.handle (/snapshot/cli/node_modules/@lando/core/lib/events.js)
    at /snapshot/cli/node_modules/@lando/core/lib/events.js
From previous event:
    at AsyncEvents.emit (/snapshot/cli/node_modules/@lando/core/lib/events.js)
    at /snapshot/cli/node_modules/@lando/core/lib/app.js
From previous event:
    at App.init (/snapshot/cli/node_modules/@lando/core/lib/app.js)
    at /snapshot/cli/bin/lando.js
    at process.processImmediate (node:internal/timers:471:21)
From previous event:
    at Object.<anonymous> (/snapshot/cli/bin/lando.js)
    at Module._compile (pkg/prelude/bootstrap.js:1926:22)
    at Module._extensions..js (node:internal/modules/cjs/loader:1166:10)
    at Module.load (node:internal/modules/cjs/loader:988:32)
    at Module._load (node:internal/modules/cjs/loader:834:12)
    at Function.runMain (pkg/prelude/bootstrap.js:1979:12)
    at node:internal/main/run_main_module:17:47

My lando config is:

name: catchthatfact
recipe: wordpress
config:
  webroot: wp

env_file:
    - .env

services:
    appserver:
        run:
            - composer install

    node:
        type: node:20
        command: pnpm run -r dev
        run:
            - pnpm install
andrewg211 commented 5 months ago

Here's a work around for now:

services:
  frontend:
    type: node:18
    scanner: false
    ssl: true
    overrides:
      image: node:20
miloskroulik commented 5 months ago

Thanks. This should be fixed with the next stable release. The problem is probably that the docs reflect the latest version of the plugin, event if its not available in the lando release yet.

stebogit commented 3 months ago

it looks like this was fixed in v1.1.0

reynoldsalec commented 3 months ago

Correct!

chrillep commented 3 months ago
    overrides:
      image: "node:lts-alpine"
  if you prefer to always be on LTS