search

lando / pantheon

The Official Lando Pantheon plugin.
https://docs.lando.dev/pantheon
GNU General Public License v3.0
12 stars 18 forks source link

Needed support for PHP 8.2 #159

Closed tyllyn closed 12 months ago

tyllyn commented 1 year ago

Began work locally on upgrading a Pantheon Drupal site to PHP 8.2, and adjusted the pantheon.yml as such:

api_version: 1
php_version: 8.2`

Upon attempting to rebuild with lando rebuild, I receive the following console output:

? Are you sure you want to rebuild? Yes
Rising anew like a fire phoenix from the ashes! Rebuilding app...
No stopped containers
Pulling appserver ... error
Pulling cache     ... done
Pulling database  ... done
Pulling edge      ... done
Pulling index     ... done

ERROR: for appserver  manifest for devwithlando/pantheon-appserver:8.2-2 not found: manifest unknown: manifest unknown
ERROR: manifest for devwithlando/pantheon-appserver:8.2-2 not found: manifest unknown: manifest unknown
ERROR ==>
reynoldsalec commented 1 year ago

Reviewing https://github.com/lando/pantheon/pull/161 by @ossobuffo, should have this merged in shortly.

sharique commented 1 year ago

How to update pantheon recipe to get PHP 8.2 support?

reynoldsalec commented 12 months ago

8.2 support was added in v0.10.0 of this plugin, and should be packaged with any Lando install from v3.17.0 onwards.

reynoldsalec commented 12 months ago

FYI, note that the correct way to use different PHP versions with the Pantheon recipe is to specify the version of PHP in your pantheon.yml...IE if you have PHP defined there, Lando should respect that (although you'll probably need to run a lando rebuild for it to take effect).