lando / pantheon

The Official Lando Pantheon plugin.
https://docs.lando.dev/pantheon
GNU General Public License v3.0
11 stars 18 forks source link

Pantheon recipe does not use correct appserver image #19

Closed pcfreak30 closed 2 years ago

pcfreak30 commented 4 years ago

Tell us about your setup

What is your lando version and operating system? (note that the older your version the less likely we are to reply)

v3.0.0-rc.2 Manjaro Linux 18.1.5

Tell us about your .lando.yml

Paste in the contents of your .lando.yml this is SUPER HELPFUL for us.

name: test
recipe: test
config:
  framework: wordpress
  site: test
  id: 74433384-be67-455a-83e3-5cf137673ca7
  xdebug: true
services:
  appserver:
    overrides:
      image: devwithlando/pantheon-appserver:7.0-2

It is also helpful to include other relevant config files. For example, include pantheon.yml for a pantheon recipe if applicable. Include php.ini or mysql.cnf if you are overriding our defualt config.

pantheon.yml

api_version: 1
php_version: 7.0

Tell us about the command you were running

lando init --source pantheon

Tell us about the error you got / Tell us generally about your bug

It appears to use the general nginx server as appserver vs the php-fpm image. I had to use an override base on the builder.js code to force it to use the correct one.

Tell us more

Could better documentation have prevented this issue? if so what should we change? Does this bug prevent you from using lando?

If I was not able to work around this, it would have forced me yo use a generic LEMP recipe.

pirog commented 4 years ago

@pcfreak30 i cannot replicate this. Pretty sure this was fixed with https://github.com/lando/lando/blob/a50cc1ead742dee514eb0a9dee1b2eae9fc7eeec/plugins/lando-pantheon/recipes/pantheon/builder.js#L82-L83

I'd update to the latest version, you are VERY far back, and lando rebuild to resolve