lando / pantheon

The Official Lando Pantheon plugin.
https://docs.lando.dev/pantheon
GNU General Public License v3.0
12 stars 18 forks source link

X-Pantheon-Session should be sent in a header not a cookie. #229

Closed kporras07 closed 7 months ago

kporras07 commented 7 months ago

Hi Lando folks 👋

At Pantheon we recently made a API change for terminus in which we removed the old way we had (Terminux 0.x) for requests to authenticate to the API using cookies. After we moved 100% of requests to Terminus API we started getting support tickets that Lando is not working for clients.

After taking a look to the code, we found that Lando was using cookies but it should really be using the actual headers.

This PR is UNTESTED, hopefully a guide for you to understand what should happen here.

Thanks!

netlify[bot] commented 7 months ago

Deploy Preview for lando-pantheon ready!

Name Link
Latest commit da68e975ceddd4d5cb98c90712f63c88235ed8f1
Latest deploy log https://app.netlify.com/sites/lando-pantheon/deploys/660b07ddb7d6170008dedef2
Deploy Preview https://deploy-preview-229--lando-pantheon.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

Lighthouse
1 paths audited
Performance: 97 (🟢 up 1 from production)
Accessibility: 98 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

reynoldsalec commented 7 months ago

My manual testing looks good and the relevant test suites are giving greenlights. I'm going to cut a release with this in it so we can get people back up-and-running, thanks @kporras07 for addressing it so quickly, you're a FOSS hero!

ItsMarioSouza commented 7 months ago

@reynoldsalec - will there be a new release for the current stable version of Lando, v3.20.*? If not, is there a way to manually update or apply this update? Thanks in advance, sorry for the ignorance.