lando / php

The Official Lando PHP plugin.
https://docs.lando.dev/php
GNU General Public License v3.0
16 stars 16 forks source link

Update php support according to https://www.php.net/supported-version… #121

Closed tvlooy closed 2 months ago

tvlooy commented 2 months ago

…s.php

Bare minimum self-checks

What do you think of a person who only does the bare minimum?

Pieces of flare

Finally

If you have any issues or need help please join the #contributors channel in the Lando slack and someone will gladly help you out!

You can also check out the coder guide.

netlify[bot] commented 2 months ago

Deploy request for lando-php pending review.

Visit the deploys page to approve it

Name Link
Latest commit 8789d69760c116cb9399194b00584fc4bc995975
tvlooy commented 2 months ago

@pirog @reynoldsalec can you review?

reynoldsalec commented 2 months ago

So I hate this, but the big issue with the way Lando v3 services handle the "default" version is this: if we update the default version, next time people rebuild their apps, they'll get a dramatically different version of PHP. There is a fairly large number of users who are relying on the "default" setting, and changing it from underneath them will probably be problematic.

This is a big reason @pirog is planning on eliminating default versions in v4 and moving to a world where the Landofile explicitly declares your service version.

Does that makes sense @tvlooy?

pirog commented 2 months ago

for additional context we are going to release a new php service built on the new Lando 4 service api within the next few months and this should make "default version management" a thing of the past.

tvlooy commented 2 months ago

Oh, yes that does make sense. Great to hear there's a new php service on the way. Where can I get a notification if this is released? We have quite a few developers that use Lando, and I think they would be happy to try it out

reynoldsalec commented 2 months ago

I'd watch this repo via GitHub (should notify you on releases) and for more general Lando v4 updates, sign-up to the newsletter (see signup at the bottom of the docs homepage: https://docs.lando.dev).

Also doesn't hurt to be on the Lando Slack; you can always ask questions there, especially on the #contributors channel: https://www.launchpass.com/devwithlando

Going to close this out for now, but thanks for taking the time to contribute!