search

lando / php

The Official Lando PHP plugin.
https://docs.lando.dev/php
GNU General Public License v3.0
16 stars 16 forks source link

The error_reporting setting excludes E_DEPRECATED notices #2

Open aadmathijssen opened 2 years ago

aadmathijssen commented 2 years ago

Hi,

I was wondering why the error_reporting setting is set to E_ALL & ~E_DEPRECATED (see line 42 of the local php.ini ) instead of E_ALL.

The development version of the php.ini of PHP itself sets the value error_reporting to E_ALL:

https://github.com/php/php-src/blob/PHP-7.4/php.ini-development#L484 https://github.com/php/php-src/blob/PHP-8.0/php.ini-development#L484 https://github.com/php/php-src/blob/PHP-8.1/php.ini-development#L484

Other development solutions for PHP that I am familiar with, Homebrew and Docksal, also adhere to this default.

I prefer to have this included, as it helps in finding potential deprecations early.

But maybe there is a valid reason to exclude E_DEPRECATED notices that I'm not aware of.

Thanks.

Aad

reynoldsalec commented 2 years ago

Good question @aadmathijssen; it's been a LONG time since anyone thought about this. Consulting the institutional memory, it sounds like we probably set something that made sense at the time for Drupal-y people or possibly that was the old PHP default years ago, and never changed it.

We're not making too many changes like this until Lando 4.x (trying to reduce variability), but this is a really good reminder for us to base the 4.x config off the established PHP recipe and to make it even easier to configure these values.

Of course for the present, you can override that setting in your own php.ini