search

lando / php

The Official Lando PHP plugin.
https://docs.lando.dev/php
GNU General Public License v3.0
16 stars 16 forks source link

Add support for PHP 8.3. #81

Closed pfrenssen closed 9 months ago

pfrenssen commented 10 months ago

Fixes #77

netlify[bot] commented 10 months ago

Deploy Preview for lando-php ready!

Name Link
Latest commit 8c528c71addf2c79bfdf282397307b77857d646c
Latest deploy log https://app.netlify.com/sites/lando-php/deploys/6578bacb01673f000800382c
Deploy Preview https://deploy-preview-81--lando-php.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

pfrenssen commented 10 months ago

I based this on #51. I am only unsure about the composer version to use. In the image I updated Composer to 2.6.5, but is it preferred to stick to the Composer LTS release 2.2.22?

pfrenssen commented 10 months ago

Ran a successful test for the basic 8.3 example locally:

$ ./lando/php/node_modules/.bin/leia examples/8.3/README.md -c 'Destroy tests'

  php-8-3-example
    ✓ should start up successfully (96057ms)
    ✓ should use 8 3 as the default php version (1233ms)
    ✓ should use 10 x as the default postgresql client version (1183ms)
    ✓ should use apache 2 4 as the default webserver version (1178ms)
    ✓ should only serve over http by default (1170ms)
    ✓ should serve from the app root by default (1203ms)
    ✓ should have a 1 g php mem limit on appserver (1178ms)
    ✓ should have composer memory limit set to 1 (1151ms)
    ✓ should install composer 2 x by default (1178ms)
    ✓ should have unlimited memory for php for cli opts (1960ms)
    ✓ should not enable xdebug by default (1170ms)
    ✓ should have a path info and path translated server vars (2401ms)
    ✓ should use specified php version if given (1185ms)
    ✓ should install composer 2 5 6 if version number is set (1229ms)
    ✓ should serve via nginx if specified (1137ms)
    ✓ should serve via https if specified (1137ms)
    ✓ should enable xdebug if specified (1152ms)
    ✓ should not serve port 80 for cli (1131ms)
    ✓ should install the composer 2 x using the false flag (1180ms)
    ✓ should use custom php ini if specified (2348ms)
    ✓ should inherit overrides from its generator (2260ms)
    ✓ should be able to run build steps on lando managed nginx service (1139ms)
    ✓ should be able to override lando managed nginx service (2259ms)
    ✓ should set path info and path translated if appropriate (6787ms)
    ✓ should allow cli services to specify a boot up command (1027ms)
    ✓ should install the latest composer 2 x by default (1174ms)
    ✓ should have node 14 installed in cli service (685ms)
    ✓ should be destroyed with success (4254ms)

  28 passing (2m)

Done in 141.45s.
rkasza92 commented 10 months ago

Redis extension is fixed at 5.3.7 in the Dockerfile. The recent one is https://pecl.php.net/package/redis/6.0.2 Shouln't we use the most recent one instead?

Does the 8.3-apache version build for you? I tried to build that Dockerfile locally but when it starts to install imagick it throws this error (with FPM version it builds fine for some reason, maybe I was doing something wrong):

docker build -t custom1/php:8.3-apache-4 .

88.21 running: make INSTALL_ROOT="/tmp/pear/temp/pear-build-defaultusertXZnaA/install-imagick-3.7.0" install
88.22 Parse /tmp/pear/temp/imagick/ImagickDraw.stub.php to generate /tmp/pear/temp/imagick/ImagickDraw_arginfo.h
88.25 --2023-11-28 12:49:59--  https://github.com/nikic/PHP-Parser/archive/v5.0.0alpha3.tar.gz
88.28 Resolving github.com (github.com)... 140.82.121.4
88.32 Connecting to github.com (github.com)|140.82.121.4|:443... connected.
88.66 HTTP request sent, awaiting response... 302 Found
88.66 Location: https://codeload.github.com/nikic/PHP-Parser/tar.gz/refs/tags/v5.0.0alpha3 [following]
88.66 --2023-11-28 12:49:59--  https://codeload.github.com/nikic/PHP-Parser/tar.gz/refs/tags/v5.0.0alpha3
88.70 Resolving codeload.github.com (codeload.github.com)... 140.82.121.10
88.74 Connecting to codeload.github.com (codeload.github.com)|140.82.121.10|:443... connected.
89.00 HTTP request sent, awaiting response... 200 OK
89.00 Length: 161604 (158K) [application/x-gzip]
89.00 Saving to: 'v5.0.0alpha3.tar.gz'
89.00 
89.08      0K .......... .......... .......... .......... .......... 31%  631K 0s
89.12     50K .......... .......... .......... .......... .......... 63% 1.22M 0s
89.13    100K .......... .......... .......... .......... .......... 95% 5.80M 0s
89.13    150K .......                                               100% 5.24M=0.1s
89.13 
89.13 2023-11-28 12:49:59 (1.19 MB/s) - 'v5.0.0alpha3.tar.gz' saved [161604/161604]
89.13 
89.14 PHP-Parser-5.0.0alpha3/.php-cs-fixer.dist.php
89.14 PHP-Parser-5.0.0alpha3/LICENSE
89.14 PHP-Parser-5.0.0alpha3/README.md
89.14 PHP-Parser-5.0.0alpha3/bin/
89.14 PHP-Parser-5.0.0alpha3/bin/php-parse
89.14 PHP-Parser-5.0.0alpha3/composer.json
89.14 PHP-Parser-5.0.0alpha3/grammar/
89.14 PHP-Parser-5.0.0alpha3/grammar/README.md
89.14 PHP-Parser-5.0.0alpha3/grammar/parser.template
89.14 PHP-Parser-5.0.0alpha3/grammar/php.y
89.14 PHP-Parser-5.0.0alpha3/grammar/phpyLang.php
89.14 PHP-Parser-5.0.0alpha3/grammar/rebuildParsers.php
89.14 PHP-Parser-5.0.0alpha3/lib/
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/Builder.php
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/Builder/
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/Builder/ClassConst.php
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/Builder/Class_.php
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/Builder/Declaration.php
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/Builder/EnumCase.php
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/Builder/Enum_.php
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/Builder/FunctionLike.php
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/Builder/Function_.php
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/Builder/Interface_.php
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/Builder/Method.php
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/Builder/Namespace_.php
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/Builder/Param.php
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/Builder/Property.php
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/Builder/TraitUse.php
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/Builder/TraitUseAdaptation.php
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/Builder/Trait_.php
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/Builder/Use_.php
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/BuilderFactory.php
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/BuilderHelpers.php
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/Comment.php
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/Comment/
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/Comment/Doc.php
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/ConstExprEvaluationException.php
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/ConstExprEvaluator.php
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/Error.php
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/ErrorHandler.php
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/ErrorHandler/
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/ErrorHandler/Collecting.php
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/ErrorHandler/Throwing.php
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/Internal/
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/Internal/DiffElem.php
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/Internal/Differ.php
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/Internal/PrintableNewAnonClassNode.php
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/Internal/TokenPolyfill.php
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/Internal/TokenStream.php
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/JsonDecoder.php
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/Lexer.php
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/Lexer/
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/Lexer/Emulative.php
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/Lexer/TokenEmulator/
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/Lexer/TokenEmulator/AttributeEmulator.php
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/Lexer/TokenEmulator/CoaleseEqualTokenEmulator.php
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/Lexer/TokenEmulator/EnumTokenEmulator.php
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/Lexer/TokenEmulator/ExplicitOctalEmulator.php
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/Lexer/TokenEmulator/FlexibleDocStringEmulator.php
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/Lexer/TokenEmulator/FnTokenEmulator.php
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/Lexer/TokenEmulator/KeywordEmulator.php
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/Lexer/TokenEmulator/MatchTokenEmulator.php
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/Lexer/TokenEmulator/NullsafeTokenEmulator.php
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/Lexer/TokenEmulator/NumericLiteralSeparatorEmulator.php
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/Lexer/TokenEmulator/ReadonlyFunctionTokenEmulator.php
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/Lexer/TokenEmulator/ReadonlyTokenEmulator.php
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/Lexer/TokenEmulator/ReverseEmulator.php
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/Lexer/TokenEmulator/TokenEmulator.php
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/Modifiers.php
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/NameContext.php
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node.php
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Arg.php
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/ArrayItem.php
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Attribute.php
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/AttributeGroup.php
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/ClosureUse.php
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/ComplexType.php
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Const_.php
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/DeclareItem.php
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr.php
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/ArrayDimFetch.php
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/ArrayItem.php
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/Array_.php
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/ArrowFunction.php
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/Assign.php
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/AssignOp.php
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/AssignOp/
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/AssignOp/BitwiseAnd.php
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/AssignOp/BitwiseOr.php
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/AssignOp/BitwiseXor.php
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/AssignOp/Coalesce.php
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/AssignOp/Concat.php
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/AssignOp/Div.php
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/AssignOp/Minus.php
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/AssignOp/Mod.php
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/AssignOp/Mul.php
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/AssignOp/Plus.php
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/AssignOp/Pow.php
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/AssignOp/ShiftLeft.php
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/AssignOp/ShiftRight.php
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/AssignRef.php
89.14 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/BinaryOp.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/BinaryOp/
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/BinaryOp/BitwiseAnd.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/BinaryOp/BitwiseOr.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/BinaryOp/BitwiseXor.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/BinaryOp/BooleanAnd.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/BinaryOp/BooleanOr.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/BinaryOp/Coalesce.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/BinaryOp/Concat.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/BinaryOp/Div.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/BinaryOp/Equal.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/BinaryOp/Greater.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/BinaryOp/GreaterOrEqual.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/BinaryOp/Identical.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/BinaryOp/LogicalAnd.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/BinaryOp/LogicalOr.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/BinaryOp/LogicalXor.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/BinaryOp/Minus.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/BinaryOp/Mod.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/BinaryOp/Mul.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/BinaryOp/NotEqual.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/BinaryOp/NotIdentical.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/BinaryOp/Plus.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/BinaryOp/Pow.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/BinaryOp/ShiftLeft.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/BinaryOp/ShiftRight.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/BinaryOp/Smaller.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/BinaryOp/SmallerOrEqual.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/BinaryOp/Spaceship.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/BitwiseNot.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/BooleanNot.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/CallLike.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/Cast.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/Cast/
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/Cast/Array_.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/Cast/Bool_.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/Cast/Double.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/Cast/Int_.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/Cast/Object_.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/Cast/String_.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/Cast/Unset_.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/ClassConstFetch.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/Clone_.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/Closure.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/ClosureUse.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/ConstFetch.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/Empty_.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/Error.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/ErrorSuppress.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/Eval_.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/Exit_.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/FuncCall.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/Include_.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/Instanceof_.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/Isset_.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/List_.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/Match_.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/MethodCall.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/New_.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/NullsafeMethodCall.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/NullsafePropertyFetch.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/PostDec.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/PostInc.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/PreDec.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/PreInc.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/Print_.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/PropertyFetch.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/ShellExec.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/StaticCall.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/StaticPropertyFetch.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/Ternary.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/Throw_.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/UnaryMinus.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/UnaryPlus.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/Variable.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/YieldFrom.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Expr/Yield_.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/FunctionLike.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Identifier.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/InterpolatedStringPart.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/IntersectionType.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/MatchArm.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Name.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Name/
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Name/FullyQualified.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Name/Relative.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/NullableType.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Param.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/PropertyItem.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Scalar.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Scalar/
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Scalar/DNumber.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Scalar/Encapsed.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Scalar/EncapsedStringPart.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Scalar/Float_.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Scalar/Int_.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Scalar/InterpolatedString.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Scalar/LNumber.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Scalar/MagicConst.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Scalar/MagicConst/
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Scalar/MagicConst/Class_.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Scalar/MagicConst/Dir.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Scalar/MagicConst/File.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Scalar/MagicConst/Function_.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Scalar/MagicConst/Line.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Scalar/MagicConst/Method.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Scalar/MagicConst/Namespace_.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Scalar/MagicConst/Trait_.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Scalar/String_.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/StaticVar.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Stmt.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Stmt/
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Stmt/Break_.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Stmt/Case_.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Stmt/Catch_.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Stmt/ClassConst.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Stmt/ClassLike.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Stmt/ClassMethod.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Stmt/Class_.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Stmt/Const_.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Stmt/Continue_.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Stmt/DeclareDeclare.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Stmt/Declare_.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Stmt/Do_.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Stmt/Echo_.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Stmt/ElseIf_.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Stmt/Else_.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Stmt/EnumCase.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Stmt/Enum_.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Stmt/Expression.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Stmt/Finally_.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Stmt/For_.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Stmt/Foreach_.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Stmt/Function_.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Stmt/Global_.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Stmt/Goto_.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Stmt/GroupUse.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Stmt/HaltCompiler.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Stmt/If_.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Stmt/InlineHTML.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Stmt/Interface_.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Stmt/Label.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Stmt/Namespace_.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Stmt/Nop.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Stmt/Property.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Stmt/PropertyProperty.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Stmt/Return_.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Stmt/StaticVar.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Stmt/Static_.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Stmt/Switch_.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Stmt/Throw_.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Stmt/TraitUse.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Stmt/TraitUseAdaptation.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Stmt/TraitUseAdaptation/
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Stmt/TraitUseAdaptation/Alias.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Stmt/TraitUseAdaptation/Precedence.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Stmt/Trait_.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Stmt/TryCatch.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Stmt/Unset_.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Stmt/UseUse.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Stmt/Use_.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/Stmt/While_.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/UnionType.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/UseItem.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/VarLikeIdentifier.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Node/VariadicPlaceholder.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/NodeAbstract.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/NodeDumper.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/NodeFinder.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/NodeTraverser.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/NodeTraverserInterface.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/NodeVisitor.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/NodeVisitor/
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/NodeVisitor/CloningVisitor.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/NodeVisitor/FindingVisitor.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/NodeVisitor/FirstFindingVisitor.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/NodeVisitor/NameResolver.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/NodeVisitor/NodeConnectingVisitor.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/NodeVisitor/ParentConnectingVisitor.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/NodeVisitorAbstract.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Parser.php
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Parser/
89.15 PHP-Parser-5.0.0alpha3/lib/PhpParser/Parser/Php7.php
89.16 PHP-Parser-5.0.0alpha3/lib/PhpParser/Parser/Php8.php
89.16 PHP-Parser-5.0.0alpha3/lib/PhpParser/ParserAbstract.php
89.16 PHP-Parser-5.0.0alpha3/lib/PhpParser/ParserFactory.php
89.16 PHP-Parser-5.0.0alpha3/lib/PhpParser/PhpVersion.php
89.16 PHP-Parser-5.0.0alpha3/lib/PhpParser/PrettyPrinter.php
89.16 PHP-Parser-5.0.0alpha3/lib/PhpParser/PrettyPrinter/
89.16 PHP-Parser-5.0.0alpha3/lib/PhpParser/PrettyPrinter/Standard.php
89.16 PHP-Parser-5.0.0alpha3/lib/PhpParser/PrettyPrinterAbstract.php
89.16 PHP-Parser-5.0.0alpha3/lib/PhpParser/Token.php
89.16 PHP-Parser-5.0.0alpha3/lib/PhpParser/compatibility_tokens.php
89.16 PHP-Parser-5.0.0alpha3/phpstan-baseline.neon
89.16 PHP-Parser-5.0.0alpha3/phpstan.neon.dist
89.18 Saved /tmp/pear/temp/imagick/ImagickDraw_arginfo.h
89.19 Parse /tmp/pear/temp/imagick/ImagickPixel.stub.php to generate /tmp/pear/temp/imagick/ImagickPixel_arginfo.h
89.22 Saved /tmp/pear/temp/imagick/ImagickPixel_arginfo.h
89.23 Parse /tmp/pear/temp/imagick/Imagick.stub.php to generate /tmp/pear/temp/imagick/Imagick_arginfo.h
89.29 In /tmp/pear/temp/imagick/Imagick.stub.php:
89.29 Unterminated preprocessor conditions
89.29 make: *** [Makefile:196: /tmp/pear/temp/imagick/Imagick_arginfo.h] Error 1
89.30 ERROR: `make INSTALL_ROOT="/tmp/pear/temp/pear-build-defaultusertXZnaA/install-imagick-3.7.0" install' failed
------
Dockerfile:6
--------------------
   5 |     # Install dependencies we need
   6 | >>> RUN mkdir -p /usr/share/man/man1 /usr/share/man/man7 \
   7 | >>>   && apt -y update && apt-get install -y \
   8 | >>>     gnupg2 \
   9 | >>>     wget \
  10 | >>>   && echo 'deb http://apt.postgresql.org/pub/repos/apt/ bullseye-pgdg main' >> /etc/apt/sources.list.d/pgdg.list \
  11 | >>>   && wget --quiet -O - https://www.postgresql.org/media/keys/ACCC4CF8.asc | apt-key add - \
  12 | >>>   && apt-get update && apt-get install -y \
  13 | >>>     bzip2 \
  14 | >>>     default-mysql-client \
  15 | >>>     exiftool \
  16 | >>>     git-core \
  17 | >>>     imagemagick \
  18 | >>>     libbz2-dev \
  19 | >>>     libc-client-dev \
  20 | >>>     libfreetype6-dev \
  21 | >>>     libicu-dev \
  22 | >>>     libjpeg62-turbo-dev \
  23 | >>>     libkrb5-dev \
  24 | >>>     libldap2-dev \
  25 | >>>     libmagickwand-dev \
  26 | >>>     libmemcached-dev \
  27 | >>>     libpng-dev \
  28 | >>>     libpq-dev \
  29 | >>>     libssl-dev \
  30 | >>>     libwebp-dev \
  31 | >>>     libxml2-dev \
  32 | >>>     libzip-dev \
  33 | >>>     libonig-dev \
  34 | >>>     openssl \
  35 | >>>     postgresql-client-10 \
  36 | >>>     pv \
  37 | >>>     rsync \
  38 | >>>     ssh \
  39 | >>>     unzip \
  40 | >>>     wget \
  41 | >>>     xfonts-75dpi \
  42 | >>>     xfonts-base \
  43 | >>>     zlib1g-dev \
  44 | >>>   && pecl install apcu \
  45 | >>>   && pecl install imagick \
  46 | >>>   && pecl install memcached \
  47 | >>>   && pecl install oauth \
  48 | >>>   && pecl install redis-5.3.7 \
  49 | >>>   && pecl install xdebug \
  50 | >>>   && docker-php-ext-configure ldap --with-libdir=lib/$(uname -m)-linux-gnu/ \
  51 | >>>   && docker-php-ext-enable apcu \
  52 | >>>   && docker-php-ext-enable imagick \
  53 | >>>   && docker-php-ext-enable memcached \
  54 | >>>   && docker-php-ext-enable oauth \
  55 | >>>   && docker-php-ext-enable redis \
  56 | >>>   && docker-php-ext-install bcmath \
  57 | >>>   && docker-php-ext-install bz2 \
  58 | >>>   && docker-php-ext-install calendar \
  59 | >>>   && docker-php-ext-install exif \
  60 | >>>   && docker-php-ext-install gettext \
  61 | >>>   && docker-php-ext-install intl \
  62 | >>>   && docker-php-ext-install ldap \
  63 | >>>   && docker-php-ext-install mbstring \
  64 | >>>   && docker-php-ext-install mysqli \
  65 | >>>   && docker-php-ext-install opcache \
  66 | >>>   && docker-php-ext-install pcntl \
  67 | >>>   && docker-php-ext-install pdo \
  68 | >>>   && docker-php-ext-install pdo_mysql \
  69 | >>>   && docker-php-ext-install pdo_pgsql \
  70 | >>>   && docker-php-ext-install soap \
  71 | >>>   && docker-php-ext-install zip \
  72 | >>>   && php -r "copy('https://getcomposer.org/installer', 'composer-setup.php');" \
  73 | >>>   && php composer-setup.php --install-dir=/usr/local/bin --filename=composer --version=2.6.5 \
  74 | >>>   && php -r "unlink('composer-setup.php');" \
  75 | >>>   && chsh -s /bin/bash www-data && mkdir -p /var/www/.composer && chown -R www-data:www-data /var/www \
  76 | >>>   && apt-get -y clean \
  77 | >>>   && apt-get -y autoclean \
  78 | >>>   && apt-get -y autoremove \
  79 | >>>   && rm -rf /var/lib/apt/lists/* && rm -rf && rm -rf /var/lib/cache/* && rm -rf /var/lib/log/* && rm -rf /tmp/* \
  80 | >>>   && PHP_OPENSSL=yes docker-php-ext-configure imap --with-kerberos --with-imap-ssl \
  81 | >>>   && docker-php-ext-install imap \
  82 | >>>   && docker-php-ext-configure gd --enable-gd --with-jpeg --with-webp --with-freetype \
  83 | >>>   && docker-php-ext-install gd
  84 |     
--------------------
ERROR: failed to solve: process "/bin/sh -c mkdir -p /usr/share/man/man1 /usr/share/man/man7   && apt -y update && apt-get install -y     gnupg2     wget   && echo 'deb http://apt.postgresql.org/pub/repos/apt/ bullseye-pgdg main' >> /etc/apt/sources.list.d/pgdg.list   && wget --quiet -O - https://www.postgresql.org/media/keys/ACCC4CF8.asc | apt-key add -   && apt-get update && apt-get install -y     bzip2     default-mysql-client     exiftool     git-core     imagemagick     libbz2-dev     libc-client-dev     libfreetype6-dev     libicu-dev     libjpeg62-turbo-dev     libkrb5-dev     libldap2-dev     libmagickwand-dev     libmemcached-dev     libpng-dev     libpq-dev     libssl-dev     libwebp-dev     libxml2-dev     libzip-dev     libonig-dev     openssl     postgresql-client-10     pv     rsync     ssh     unzip     wget     xfonts-75dpi     xfonts-base     zlib1g-dev   && pecl install apcu   && pecl install imagick   && pecl install memcached   && pecl install oauth   && pecl install redis-5.3.7   && pecl install xdebug   && docker-php-ext-configure ldap --with-libdir=lib/$(uname -m)-linux-gnu/   && docker-php-ext-enable apcu   && docker-php-ext-enable imagick   && docker-php-ext-enable memcached   && docker-php-ext-enable oauth   && docker-php-ext-enable redis   && docker-php-ext-install bcmath   && docker-php-ext-install bz2   && docker-php-ext-install calendar   && docker-php-ext-install exif   && docker-php-ext-install gettext   && docker-php-ext-install intl   && docker-php-ext-install ldap   && docker-php-ext-install mbstring   && docker-php-ext-install mysqli   && docker-php-ext-install opcache   && docker-php-ext-install pcntl   && docker-php-ext-install pdo   && docker-php-ext-install pdo_mysql   && docker-php-ext-install pdo_pgsql   && docker-php-ext-install soap   && docker-php-ext-install zip   && php -r \"copy('https://getcomposer.org/installer', 'composer-setup.php');\"   && php composer-setup.php --install-dir=/usr/local/bin --filename=composer --version=2.6.5   && php -r \"unlink('composer-setup.php');\"   && chsh -s /bin/bash www-data && mkdir -p /var/www/.composer && chown -R www-data:www-data /var/www   && apt-get -y clean   && apt-get -y autoclean   && apt-get -y autoremove   && rm -rf /var/lib/apt/lists/* && rm -rf && rm -rf /var/lib/cache/* && rm -rf /var/lib/log/* && rm -rf /tmp/*   && PHP_OPENSSL=yes docker-php-ext-configure imap --with-kerberos --with-imap-ssl   && docker-php-ext-install imap   && docker-php-ext-configure gd --enable-gd --with-jpeg --with-webp --with-freetype   && docker-php-ext-install gd" did not complete successfully: exit code: 1
pfrenssen commented 10 months ago

I have seen that error earlier today but I can build it now. I have purged my docker image cache while I was working on this, maybe that helps?

$ docker build -t devwithlando/php:8.3-apache-4 .
[ ... ]
Removing intermediate container 5363ad0bc152
 ---> b62b633281dd
Successfully built b62b633281dd
Successfully tagged devwithlando/php:8.3-apache-4

I had to stop on this for today. I had some trouble getting the images-stable and images-edge tests running locally.

pfrenssen commented 10 months ago

Updated to v6.0.2 of the Redis extension in both images. They both can be built successfully.

pfrenssen commented 10 months ago

@reynoldsalec do you have the privilege to activate the GitHub Actions for this PR? It would be great if we can see the test results.

I am getting errors locally when trying to start the images-edge and images-stable examples.

$ cd ./examples/images-stable/8.3-apache-4
$ lando start
ERROR ==> php version 8.3 is not supported
$ lando rebuild -y
ERROR ==> php version 8.3 is not supported
$ lando destroy
ERROR ==> php version 8.3 is not supported
$ rm -rf ~/.lando/cache
$ lando start
Let's get this party started! Starting app lando-php-stable83apache...
ERROR ==> php version 8.3 is not supported

This php version 8.3 is not supported error is possibly related to the version of Xdebug used in the PHP image. Only the latest 3.3-alpha versions of the PECL package are supporting it.

Due to this issue the tests for these examples also fail locally:

$ yarn leia examples/images-stable/8.3-apache-4/README.md
[...]
STDERR: ERROR ==> php version 8.3 is not supported

I am using the 3.3-alpha package in the images, and the normal 8.3 example and test run fine. But the images-stable and images-edge are supposed to extend the base image, but they don't even seem to get the chance to be built.

reynoldsalec commented 10 months ago

Just approved the test runs @pfrenssen, looking at the diffs this looks spot on to me, although it does look like there might be some issue with the imagick build. I think it may just be an incompatibility of imagick with PHP8.3 on Debian/Ubuntu...see https://github.com/Imagick/imagick/issues/630 and https://github.com/mlocati/docker-php-extension-installer/pull/811, looks like they were waiting for the next tagged build to get added, since the master branch of imagick was working for them.

If you have interest in becoming a maintainer of the PHP plugin, we should chat, would love to have a PHP wizard (or two) to help keep this plugin up-to-date!

pfrenssen commented 10 months ago

@reynoldsalec thanks a lot! I'll keep an eye on those two MRs. Thanks for the maintainership offer! I can help out a bit triaging the issue queue, but as I'm just getting my feet wet in the Lando ecosystem (this is my first PR), I don't really have the skills to implement new features.

reynoldsalec commented 10 months ago

For sure @pfrenssen, maybe consider it more a "co-maintainer" type gig...really just having assistance watching the issue queues and doing updates would be a huge help. And we'd be down to do regular meetings with you to go over questions and help you learn deeper Lando concepts. No pressure! :)

NickDickinsonWilde commented 10 months ago

@pfrenssen any support I can give you here? Very much want this for myself this weekend. (Aka happy to debug that failing 8.3 test but don't want to do too much overlap if you are currently debugging it)

@reynoldsalec failing test 1 looks like it is about lack of credentials for docker hub

run docker/login-action@v2 Error: Username and password required

pfrenssen commented 10 months ago

@NickDickinsonWilde thanks for the offer! I have invited you to collaborate on the fork. This is not actionable for me right now, so any help is much appreciated.

reynoldsalec commented 9 months ago

Looks like we're good on the test runs now, when we make Lando 3.21 this will be included. Thanks @pfrenssen + @NickDickinsonWilde if you want to upgrade prior to 3.21, you'll need to clone the PHP plugin repo into ~/.lando/plugins/@lando