search

lando / php

The Official Lando PHP plugin.
https://docs.lando.dev/php
GNU General Public License v3.0
16 stars 16 forks source link

issue #92 do not use config for Xdebug 2 (outdated - causes problems in xdebug3 eg on php 8.1) #93

Open zuernBernhard opened 9 months ago

zuernBernhard commented 9 months ago

…for xdebug 2 since current php-versions come with xdebug3

netlify[bot] commented 9 months ago

Deploy request for lando-php pending review.

Visit the deploys page to approve it

Name Link
Latest commit 0fd7101f09a523d6c1f0a18fad6e7d10d05937c5
reynoldsalec commented 9 months ago

The build issues with the php 8.3 image should be unrelated to your changes, but would be awesome to figure out what's going on there. Probably related to the failure in https://github.com/lando/php/pull/93, although it's interesting that apache fails here.

General comment, but shouldn't we leave in the xdebug 2 config (maybe adding a comment), since older versions of PHP will be still using xdebug 2 and will need that config?

AaronFeledy commented 9 months ago

I agree that we shouldn't remove this. Older PHP images with Xdebug 2 use this same config file so removing the older config would break those. The more correct solution is probably to have separate configs for the different versions.