search

lando / php

The Official Lando PHP plugin.
https://docs.lando.dev/php
GNU General Public License v3.0
16 stars 16 forks source link

Fix GitHub Actions for not deploying every Lando PHP image to Dockerhub #98

Closed kaszarobert closed 7 months ago

kaszarobert commented 7 months ago

https://github.com/lando/php/issues/77#issuecomment-1943963779:

It looks like something is not right in github actions file. It seems like it's only building php 7.3 https://github.com/lando/php/actions/runs/7186820860/job/19573056931

As you can see https://hub.docker.com/r/devwithlando/php/tags?page=1&name=7.3 is updated a few hours ago, but https://hub.docker.com/r/devwithlando/php/tags?page=1&name=8.2 is updated 9 months ago, and 8.3 is not in there.

tvlooy commented 7 months ago

@kaszarobert I made an attempt to fix this. I suppose it's not exactly the best way, or like it was intended in github actions but this seems to work and could be a good workaround for now.

tvlooy commented 7 months ago

I referenced the commit that I think introduced the problem.

reynoldsalec commented 7 months ago

@tvlooy you're totally right, the build matrix is the root of the problem here. I think I'm just going to hardcode the lando-version right now; I tried a few variations on the build matrix and wasn't able to find a way to do include it in there (other than doing what you did, repeat it across all the include items). You can see my approach (and a fix for those broken 8.3 builds) here if you're interested: https://github.com/lando/php/pull/101/files

Thanks for flagging this and finding the issue @tvlooy!

tvlooy commented 7 months ago

Thanks so much! 👍