search

lando / postgres

The Official Postgres Lando Plugin
https://docs.lando.dev/postgres
GNU General Public License v3.0
0 stars 1 forks source link

Better Healthcheck Testing/Blank database name #37

Open reynoldsalec opened 6 months ago

reynoldsalec commented 6 months ago

We just implemented a fix to handle situations where the user specifies blank dbname/username for the db config. Ex:

services:
  database:
    type: postgres
      creds:
        user: customusername
        database: customdbname

The fix: https://github.com/lando/postgres/commit/893831aca236240ddeb410663a46b8d617b0d6fe

I put in a "test case" in the custom example to make sure a blank user wouldn't fail the healthcheck or otherwise create problems, however, I'm not testing blank database values. From some quick manual testing it looked like those worked ok, but would be good to explicitly test this.