search

lando / setup-lando

Set up your GitHub Actions workflow with a specific version of Lando.
https://docs.lando.dev/install
GNU General Public License v3.0
7 stars 6 forks source link

Setup script not working for WSL2 #42

Closed yorkshire-pudding closed 5 months ago

yorkshire-pudding commented 5 months ago

I had installed lando inside WSL2 (started on Ubuntu 18.04 LTS, currently on 20.04 LTS) and it works fine. I was wanting to upgrade from 3.20.8 within WSL2 but the script didn't work.

It fell over on this line: https://github.com/lando/setup-lando/blob/3e8d9b1e262f985408321d0258dd56a93043bcdf/setup-lando.sh#L131

And failed the test for architecture. As it couldn't find the directory (I checked and it doesn't exist). I modified the script to use

arch="$(uname -m)"

And it then worked flawlessly.

The command arch also worked.

I don't know if that path was used for a reason rather than the command?

pirog commented 5 months ago

i think generally the reason you do that is to ensure you are using a known quantity as opposed to whatever happens to be first in PATH which could hypothetically be exploited.

i think in this scenario its probably ok to fallback to using something in PATH though.

yorkshire-pudding commented 5 months ago

Thanks for the explanation. In my machine, and I don't know how common it is, I found uname under /bin.

Wow - that was quick! PR looks good to me